Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT remove prerelease flag for Python 3.12 #27605

Merged
merged 3 commits into from Oct 18, 2023
Merged

MAINT remove prerelease flag for Python 3.12 #27605

merged 3 commits into from Oct 18, 2023

Conversation

glemaitre
Copy link
Member

Remove the prerelease flag since Python 3.12 is already released.

@glemaitre glemaitre mentioned this pull request Oct 17, 2023
Merged
16 tasks
@github-actions
Copy link

github-actions bot commented Oct 17, 2023 •
edited

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 1d8ae06. Link to the linter CI: here

ogrisel
ogrisel approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please trigger a wheel build in this PR with [cd build gh] and assuming it's green, LGTM.

@lesteve
Copy link
Member

lesteve commented Oct 17, 2023

I think we can also remove CIBW_PRERELEASE_PYTHONS: True in build_tools/cirrus/arm_wheel.yml

@lesteve
Copy link
Member

lesteve commented Oct 18, 2023

I pushed a cd build commit and enabled auto-merge

@lesteve lesteve enabled auto-merge (squash) October 18, 2023 08:44
@lesteve lesteve merged commit eadd9a0 into scikit-learn:main Oct 18, 2023
47 of 49 checks passed
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Oct 18, 2023
@glemaitre @lesteve
MAINT remove prerelease flag for Python 3.12 (scikit-learn#27605)
cb7816d 
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
glemaitre added a commit that referenced this pull request Oct 23, 2023
@glemaitre @lesteve
MAINT remove prerelease flag for Python 3.12 (#27605)
e43ad8b 
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Oct 31, 2023
@glemaitre @lesteve
MAINT remove prerelease flag for Python 3.12 (scikit-learn#27605)
9c0b4b2 
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@glemaitre @lesteve @REDVM
MAINT remove prerelease flag for Python 3.12 (scikit-learn#27605)
518d1b2 
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@betatim betatim betatim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@glemaitre @lesteve @ogrisel @betatim