Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Remove test suite setuptools dependency for good #27420

Merged
merged 1 commit into from Sep 19, 2023
Merged

MNT Remove test suite setuptools dependency for good #27420

merged 1 commit into from Sep 19, 2023

Conversation

lesteve
Copy link
Member

@lesteve lesteve commented Sep 19, 2023

Follow-up of #27355 which was not enough to remove the setuptools dependency, since
sklearn._build_utils.openmp_helpers will import sklearn._build_utils.pre_build_helpers which will import setuptools.

Seen in #27027 e.g. this build

@lesteve lesteve added the Quick Review For PRs that are quick to review label Sep 19, 2023
@github-actions
Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: f352ad6. Link to the linter CI: here

@lesteve lesteve mentioned this pull request Sep 19, 2023
Merged
thomasjpfan
thomasjpfan approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this locally by uninstalling setuptools and running the pytest on test_import_all_consistency. LGTM

@thomasjpfan thomasjpfan merged commit 87cfae2 into scikit-learn:main Sep 19, 2023
30 of 32 checks passed
@lesteve lesteve deleted the remove-tests-setuptools-dependency branch September 20, 2023 06:10
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 20, 2023
@lesteve @glemaitre
MNT Remove test suite setuptools dependency for good (scikit-learn#27420
82c22aa 
)
jeremiedbb pushed a commit that referenced this pull request Sep 20, 2023
@lesteve @jeremiedbb
MNT Remove test suite setuptools dependency for good (#27420)
90c9a4d
lesteve added a commit to lesteve/scikit-learn that referenced this pull request Sep 28, 2023
@lesteve
MNT Remove test suite setuptools dependency for good (scikit-learn#27420
06732ea 
)
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@lesteve @REDVM
MNT Remove test suite setuptools dependency for good (scikit-learn#27420
910d8f5 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
No Changelog Needed Quick Review For PRs that are quick to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lesteve @thomasjpfan