Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Fix dropdown-related warnings #27418

Merged
merged 3 commits into from Sep 20, 2023
Merged

Conversation

ArturoAmorQ
Copy link
Member

@ArturoAmorQ ArturoAmorQ commented Sep 19, 2023

Reference Issues/PRs

Fixes #27408.

What does this implement/fix? Explain your changes.

PRs #26807 and #27022 introduced dropdowns that are currently breaking HTML anchor.

Any other comments?

This PR is a quick fix until #27127 is solved.

@ArturoAmorQ ArturoAmorQ added Quick Review For PRs that are quick to review Documentation labels Sep 19, 2023
@github-actions
Copy link

github-actions bot commented Sep 19, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 3e0877a. Link to the linter CI: here

|details-start|
**Nested parameters**
|details-split|
Nested parameters
Copy link
Member

@glemaitre glemaitre Sep 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The section is actually looking weird. I don't think we should have collapsed any of the information.

Right now, we don't have an example in the documentation that show how to make a pipeline at a first glance.

@glemaitre glemaitre self-requested a review September 19, 2023 16:47
@glemaitre
Copy link
Member

I proposed the following changes: ArturoAmorQ#3

It gives the basic usage of pipelines and still collapsed some of the details.

@glemaitre glemaitre merged commit 6638d28 into scikit-learn:main Sep 20, 2023
11 of 17 checks passed
@glemaitre
Copy link
Member

LGTM. Thanks @ArturoAmorQ

glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Sep 20, 2023
Co-authored-by: ArturoAmorQ <arturo.amor-quiroz@polytechnique.edu>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
jeremiedbb pushed a commit that referenced this pull request Sep 20, 2023
Co-authored-by: ArturoAmorQ <arturo.amor-quiroz@polytechnique.edu>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
lesteve pushed a commit to lesteve/scikit-learn that referenced this pull request Sep 28, 2023
Co-authored-by: ArturoAmorQ <arturo.amor-quiroz@polytechnique.edu>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
Co-authored-by: ArturoAmorQ <arturo.amor-quiroz@polytechnique.edu>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Quick Review For PRs that are quick to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usage of dropdowns are breaking HTML anchor
2 participants