Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC update release dates for 1.3.1 #27407

Merged
merged 1 commit into from Sep 19, 2023

Conversation

glemaitre
Copy link
Member

Part of the release 1.3.1.

Update the release dates in the changelog and in the "News" of the website.

@glemaitre glemaitre mentioned this pull request Sep 18, 2023
12 tasks
@github-actions
Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: d66b4ff. Link to the linter CI: here

Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

Comment on lines +172 to +173
<li><strong>September 2023.</strong> scikit-learn 1.3.1 is available for download (<a href="whats_new/v1.3.html#version-1-3-1">Changelog</a>).
</li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with every item we add, we can probably remove an item from the end of the list.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's decide on a release window and write it in the maintainers guide. What do you think about keeping all entries since the previous major release ? for 1.3.2 it means we keep everything since 1.2.0. In general it means for 1.X.Y we keep everything since 1.(X-1).0.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that sounds good, so we don't have to remove anything now.

@adrinjalali adrinjalali merged commit 066375f into scikit-learn:main Sep 19, 2023
30 checks passed
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Sep 19, 2023
jeremiedbb pushed a commit that referenced this pull request Sep 20, 2023
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants