-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
Release highlights for 1.3 #26526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release highlights for 1.3 #26526
Conversation
Other features that I'm thinking about are
Do you think they should end up in the highlights ? |
@jeremiedbb added metadata routing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good starting point to iterate from. LGTM
non_noisy_labels = hdbscan.labels_[hdbscan.labels_ != -1] | ||
print(f"number of clusters found: {len(np.unique(non_noisy_labels))}") | ||
|
||
v_measure_score(true_labels[hdbscan.labels_ != -1], non_noisy_labels) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit:
v_measure_score(true_labels[hdbscan.labels_ != -1], non_noisy_labels) | |
print( | |
"V-measure:", v_measure_score(true_labels[hdbscan.labels_ != -1], non_noisy_labels) | |
) |
tree.predict(X) | ||
|
||
# %% | ||
# Metadata Routing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would place this at the top.
From a practitioner‘s perspective, pricing actuaries in particular, gamma deviance HGBT are a big deal. The PR itself was pretty small, but based on a pile of work with the common loss functions. |
@lorentzenchr would you mind adding a small section for the Gamma deviance ? |
# By performing :class:`cluster.DBSCAN` over varying epsilon values | ||
# :class:`cluster.HDBSCAN` finds clusters of varying densities making it more robust to | ||
# parameter selection than :class:`cluster.DBSCAN`. More details in the | ||
# :ref:`User Guide <hdbscan>`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wording is a bit difficult here only because HDBSCAN doesn't solve exactly the DBSCAN problem for multiple epsilon, but rather a modified problem that solves for the same solutions locally. I think this is a fair-enough compromise between correctness and readability. Open to thoughts though :)
# By performing :class:`cluster.DBSCAN` over varying epsilon values | |
# :class:`cluster.HDBSCAN` finds clusters of varying densities making it more robust to | |
# parameter selection than :class:`cluster.DBSCAN`. More details in the | |
# :ref:`User Guide <hdbscan>`. | |
# By performing a modified version of :class:`cluster.DBSCAN` over multiple epsilon | |
# values simultaneously, :class:`cluster.HDBSCAN` finds clusters of varying densities | |
# making it more robust to parameter selection than :class:`cluster.DBSCAN`. | |
# More details in the :ref:`User Guide <hdbscan>`. |
Until when? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on my side.
Co-authored-by: adrinjalali <adrin.jalali@gmail.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@jeremiedbb Thank you! 🚀 |
Co-authored-by: adrinjalali <adrin.jalali@gmail.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: adrinjalali <adrin.jalali@gmail.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: adrinjalali <adrin.jalali@gmail.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
As usual, let's start with a few highlights and add more if needed in subsequent PRs.
For now I put the TargetEncoder, HDBSCAN, and missing values support in trees.
Do not hesitate to edit.
Something we should add is some news about the metadata routing but I wasn't sure how to write that. @adrinjalali would you mind adding a section (here or in a separate PR) ?