DOC add meaning of max_patches=None in _compute_n_patches
#25999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updating 'None' option for max_patches
glemaitre
reviewed
Mar 29, 2023
glemaitre
reviewed
Mar 29, 2023
glemaitre
changed the title
glemaitre
changed the title
None in _compute_n_patches
glemaitre
changed the title
None in _compute_n_patchesmax_patches=None in _compute_n_patches
|
I edited the title of the PR and the summary to reflect what changes in proposed in this PR. |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@Ily83 Would you be able to complete this PR? |
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
|
Done |
betatim
reviewed
Apr 5, 2023
sklearn/feature_extraction/image.py
Outdated
| @@ -261,8 +261,8 @@ def _compute_n_patches(i_h, i_w, p_h, p_w, max_patches=None): | |||
| max_patches : int or float, default=None | |||
| The maximum number of patches to extract. If max_patches is a float | |||
| between 0 and 1, it is taken to be a proportion of the total number | |||
| of patches. | |||
| If max_patches=None then the total number of patches will be extracted. | |||
| of patches. If `max_patches` is None it corresponds to the total number | |||
There was a problem hiding this comment.
nit: I can't really explain why but I think I prefer "If max_patches is None all possible patches are extracted.". I find "total number of patches" a bit weird.
|
@Ily83 are you planning to continue working on this PR? |
there is nothing to continue here @marenwestermann |
|
There's one more change request from a core developer that would need to be addressed. Once this is done, I think this PR can be merged. :) |
|
I just pushed the proposed change by @betatim and merge this PR |
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Jun 29, 2023
…earn#25999) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
jeremiedbb
pushed a commit
that referenced
this pull request
Jun 29, 2023
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
punndcoder28
pushed a commit
to punndcoder28/scikit-learn
that referenced
this pull request
Jul 29, 2023
…earn#25999) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
…earn#25999) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #17295
Add the meaning of
max_patches=Nonein the docstring of_compute_n_patches.It makes
_compute_n_patchesdocstring consistent withextract_2d_patchesalso.