SGD module renaming #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renamed ClassifierSGD to SGDClassifier (same for Regressor) updated setup.py files updated examples updated docs
|
Thanks Peter, I'm currently reviewing it ... |
|
My idea was more to merge the sgd into linear_model and rename sgd.py into stochastic_gradient.py rather than add a subpackage stochastic_gradient in linear_model, and I apologize for not making myself clear. Here's a pull request that does this. This positions gradient_descent.py at the same level as coordinate_descent.py and lars.py, and also puts sparse sgd into linear_model.sparse: Finally, the import paths for common objects are: from scikits.learn import linear_model |
|
+1 for fabianp proposal |
|
That sounds reasonable - I'm +1 |
glouppe
pushed a commit
to glouppe/scikit-learn
that referenced
this pull request
Jan 27, 2013
Fix issues raised by reviewers
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Nov 20, 2016
ENH: support Yields section
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finalized the renaming of SGD module.
Moved sgd into linear_model.
Renamed sgd to stochastic_gradient
Renamed ClassifierSGD to SGDClassifier (same for Regressor and Base classes).
Updated examples, docs, and build files.