Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Ensures that MultiTaskElasticNetCV passes numpydoc validation #21405

Merged
merged 4 commits into from Oct 23, 2021

Conversation

spikebh
Copy link
Contributor

@spikebh spikebh commented Oct 22, 2021

Reference Issues/PRs

Addresses #20308

What does this implement/fix? Explain your changes.

This PR ensure that MultiTaskElasticNetCV estimator passes all numpydoc validation checks.

  • fixes on MultiTaskElasticNetCV class docstring, sections were in the wrong order and some descriptions in the See Also section were missing.
  • Minor format fixes in the "fit" method.

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just an quick suggestion for improvement:

sklearn/linear_model/_coordinate_descent.py Outdated Show resolved Hide resolved
sklearn/linear_model/_coordinate_descent.py Outdated Show resolved Hide resolved
spikebh and others added 2 commits October 22, 2021 13:03
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
@spikebh
Copy link
Contributor Author

spikebh commented Oct 22, 2021

LGTM, just an quick suggestion for improvement:

Suggestions added to the commit. Thank you!

@glemaitre glemaitre merged commit ef7a028 into scikit-learn:main Oct 23, 2021
@glemaitre glemaitre added this to the 1.0.1 milestone Oct 23, 2021
@glemaitre
Copy link
Member

Thanks @spikebh

glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Oct 23, 2021
…ikit-learn#21405)

Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre added a commit that referenced this pull request Oct 25, 2021
…1405)

Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
…ikit-learn#21405)

Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
mathijs02 pushed a commit to mathijs02/scikit-learn that referenced this pull request Dec 27, 2022
…ikit-learn#21405)

Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants