-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add update CMake workflow #359
Conversation
.github/workflows/update-cmake.yml
Outdated
id: generate-token | ||
if: github.ref == 'refs/heads/master' && github.repository == 'scikit-build/cmake-python-distributions' | ||
with: | ||
app_id: ${{ secrets.SCIKIT_BUILD_BOT_APP_ID }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a bot needs to be setup to get a proper token.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need this if you select the "create PRs" permission for GHA?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from: https://github.com/peter-evans/create-pull-request/blob/main/docs/concepts-guidelines.md#workarounds-to-trigger-further-workflow-runs
I understand that a PR could be created using the default GITHUB_TOKEN, however, this PR would not trigger a CI workflow run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created an app at the organization level as users are less appropriate for this.
The app is installed only for this repo.
Secrets are set at organization level but limited to this repo for now.
This is still in draft. |
feab4e0
to
ae4c305
Compare
sample PR in #512 |
towards #186