Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add update CMake workflow #359

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Conversation

mayeut
Copy link
Contributor

@mayeut mayeut commented Apr 16, 2023

towards #186

@mayeut mayeut marked this pull request as draft April 16, 2023 11:07
id: generate-token
if: github.ref == 'refs/heads/master' && github.repository == 'scikit-build/cmake-python-distributions'
with:
app_id: ${{ secrets.SCIKIT_BUILD_BOT_APP_ID }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bot needs to be setup to get a proper token.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need this if you select the "create PRs" permission for GHA?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from: https://github.com/peter-evans/create-pull-request/blob/main/docs/concepts-guidelines.md#workarounds-to-trigger-further-workflow-runs
I understand that a PR could be created using the default GITHUB_TOKEN, however, this PR would not trigger a CI workflow run.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created an app at the organization level as users are less appropriate for this.

The app is installed only for this repo.
Secrets are set at organization level but limited to this repo for now.

@mayeut mayeut requested a review from henryiii April 16, 2023 11:24
@henryiii
Copy link
Contributor

This is still in draft.

@mayeut mayeut force-pushed the auto-bump-cmake branch 4 times, most recently from feab4e0 to ae4c305 Compare June 22, 2024 11:08
@mayeut mayeut force-pushed the auto-bump-cmake branch from ae4c305 to 2ee78bd Compare June 22, 2024 12:08
@mayeut mayeut marked this pull request as ready for review June 22, 2024 12:17
@mayeut
Copy link
Contributor Author

mayeut commented Jun 22, 2024

sample PR in #512

@mayeut mayeut requested a review from jcfr June 22, 2024 12:19
@henryiii henryiii merged commit 3e56e2e into scikit-build:main Jun 26, 2024
24 checks passed
@mayeut mayeut deleted the auto-bump-cmake branch August 3, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants