Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [#187] Add release application feature #206

Merged
merged 65 commits into from
Mar 11, 2025
Merged

feat: [#187] Add release application feature #206

merged 65 commits into from
Mar 11, 2025
+96 −11

Conversation

jjosafath
Copy link
Contributor

@jjosafath jjosafath commented Mar 7, 2025 •
edited
Loading

What & Why

This feature will allow users to make separate packages in releases for their respective applications in their go repo. This will be especially helpful for monorepos.

  • understand & fix why only one package is in the release
  • order alphabetically
  • test with 2 repos

other info

It might be good to do builds for different os, I got errors trying it, but will do that in another PR since it's not a requirement now

Sorry, something went wrong.

jjosafath added 30 commits March 4, 2025 15:03
@jjosafath
feat: add GitHub release download task to Taskfile and action.yml
e14151a
@jjosafath
fix: update action.yml to use single quotes for consistency and add n…
Loading
Loading status checks…
9a5e3d5 
…ew inputs for GitHub release downloads
@jjosafath
fix: rename task command for GitHub release downloads in action.yml
Loading
Loading status checks…
1350273
@jjosafath
fix: add description for GitHub release download task in Taskfile.yml
Loading
Loading status checks…
0e544cd
@jjosafath
fix: ordered commands alphabettically
Loading
Loading status checks…
d6eae93
@jjosafath
fix: update comments and standardize quotes in Taskfile.yml and actio…
Loading
Loading status checks…
7de85eb 
…n.yml
@jjosafath
fix: add conditional check for GitHub release repository input in act…
Loading
Loading status checks…
fb129bd 
…ion.yml
@jjosafath
fix: correct conditional check variable for GitHub release download i…
Loading
Loading status checks…
fb7e936 
…n action.yml
@jjosafath
fix: update variable references for GitHub release download in action…
Loading
Loading status checks…
9219ebd 
….yml
@jjosafath
fix: add new inputs for GitHub release options in action.yml
Loading
Loading status checks…
85773b6
@jjosafath
fix: add yes arg, since the repo using this does not trust the taskfile
Loading
Loading status checks…
bf5e414
@jjosafath
fix: add github release output variable
Loading
Loading status checks…
dfc7fcd
@jjosafath
fix: swap pattern and archive variable references in Taskfile.yml for…
Loading
Loading status checks…
1ace940 
… GitHub release download
@jjosafath
fix: update output flag to be more descriptive
Loading
Loading status checks…
f2ec520
@jjosafath
feat: add input to action for release output
Loading
Loading status checks…
b4f2040
@jjosafath
feat: added code to release application
Loading
Loading status checks…
821d919
@jjosafath
feat: add test echo script
Loading
Loading status checks…
29710a3
@jjosafath
feat: update action to build and create GitHub release
Loading
Loading status checks…
821eec5
@jjosafath
fix: remove gh refresh script
f4446d9
@jjosafath
fix: remove unnecessary GitHub authentication refresh command
Loading
Loading status checks…
ac2663e
@jjosafath
fix: simplify GitHub release command by removing unnecessary target o…
Loading
Loading status checks…
29122e4 
…ption
@jjosafath
feat: update GitHub release command to use dynamic output and tag
Loading
Loading status checks…
897c475
@jjosafath
fix: update output and file paths to use correct syntax in action.yml
Loading
Loading status checks…
f0b56d4
@jjosafath
fix: streamline release command by removing unnecessary environment v…
Loading
Loading status checks…
593dda0 
…ariables and using direct input paths
@jjosafath
fix: add GITHUB_TOKEN environment variable for release command
Loading
Loading status checks…
91c8cee
@jjosafath
fix: update GitHub release command to use dynamic target reference
Loading
Loading status checks…
ff2cbbc
@jjosafath
fix: correct syntax for GitHub release command target reference
Loading
Loading status checks…
5a4c703
@jjosafath
fix: remove unnecessary '-d' flag from GitHub release command
Loading
Loading status checks…
f4a9341
@jjosafath
feat: add AWS Lambda release step to action.yml
Loading
Loading status checks…
0b92ba3
@jjosafath
fix: correct path reference in build command for AWS Lambda
Loading
Loading status checks…
d466d4d
@jjosafath
Copy link
Contributor Author

image

image

tested on 2 repos

@jjosafath
Copy link
Contributor Author

https://github.com/schubergphilis/mcvs-scanner/releases/tag/0.8.14-rc.1

https://github.com/schubergphilis/mcvs-lambda-determiner-cdk/releases/tag/0.1.0-rc.10

sbp-bvanb
sbp-bvanb reviewed Mar 7, 2025
View reviewed changes
sbp-bvanb
sbp-bvanb reviewed Mar 7, 2025
View reviewed changes
sbp-bvanb
sbp-bvanb reviewed Mar 7, 2025
View reviewed changes
sbp-bvanb
sbp-bvanb reviewed Mar 7, 2025
View reviewed changes
sbp-bvanb
sbp-bvanb reviewed Mar 7, 2025
View reviewed changes
sbp-bvanb
sbp-bvanb reviewed Mar 7, 2025
View reviewed changes
@030
Copy link
Contributor

030 commented Mar 8, 2025 •
edited
Loading

Could you improve the naming of the artifacts as fn1-amd64 is not descriptive enough? Something like:
<cmd-app-name>-<version>-<os-type>-<arch>-<extension-if-applicable>

@jjosafath
fix: update asset_name format in action.yml to include github ref for…
Loading
Loading status checks…
97667ec 
… versioning
@jjosafath
fix: update asset_name format in action.yml to use github ref_names f…
Loading
Loading status checks…
7599ce5 
…or improved versioning
@jjosafath
fix: correct asset_name format in action.yml to use github ref_name f…
Loading
Loading status checks…
7edc637 
…or consistency
@jjosafath
fix: enhance binary build process and asset name computation in actio…
Loading
Loading status checks…
7aa52e6 
…n.yml
sbp-bvanb
sbp-bvanb reviewed Mar 10, 2025
View reviewed changes
sbp-bvanb
sbp-bvanb reviewed Mar 10, 2025
View reviewed changes
@sbp-bvanb sbp-bvanb mentioned this pull request Mar 10, 2025
Closed
@jjosafath jjosafath requested a review from sbp-bvanb March 10, 2025 10:02
sbp-bvanb
sbp-bvanb requested changes Mar 10, 2025
View reviewed changes
@jjosafath jjosafath merged commit 5a97ad6 into main Mar 11, 2025
3 checks passed
@jjosafath jjosafath deleted the add-release-application-feature branch March 11, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbp-bvanb sbp-bvanb

@jherrerasbp jherrerasbp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upload Golang artifacts
3 participants
@jjosafath @030 @sbp-bvanb