New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stock summary retrieval and decoding functionality #48
Conversation
Hi, could you please explain why this is needed. Isn't |
Hi @scheb thank you for your quick response, I have 2 options,
Because was easier to tests and less disruptive to the current method, I had pick option 1 Let me know what do you think about it. Here are the data for getQuote.json => https://gist.github.com/elminson/0d1e2afaba3b815de5cc06cc1fc1813c |
Okay, I see. Could you please do me a favor and rebase your changes onto the main branch and force-push an update? For some reason the CI didn't trigger. I hope it will after the push. I'm pretty sure there will be some code style issues popping up that we'd need to fix before we can merge. |
4f23158
to
877d188
Compare
@scheb I think now should be good if not let me know |
Please check the coding standards job, there have been some issues popping up. |
@scheb all code standards now are passing on my local please confirm :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more thing, then we're good to go.
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
fixing the failing standards |
Merged and tagged as v4.9.0 |
Description
Adding stock Summary to get information about shares and stock data
I need this information to get the float shares of a stock
If I need this information maybe another one needs it