Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move terminal test to properties #10753

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Conversation

som-snytt
Copy link
Contributor

Follow up #10751 to be more like #10752

ShellConfig has a comment that the same property for colorization is used by TypeDebugging.

Notify the Scala Store to restock the "be more like Seth" t-shirts.

@scala-jenkins scala-jenkins added this to the 2.13.15 milestone Apr 13, 2024
@som-snytt
Copy link
Contributor Author

Not what we normally mean by "test-driven development".

Mima complains about the new method. It is private[scala] and used only from Properties and also from ShellConfig (which must be run with its library version).

I don't like that Properties is performing the console probe, for a property that is used by compiler and repl.

@som-snytt som-snytt marked this pull request as ready for review April 13, 2024 18:42
@SethTisue SethTisue modified the milestones: 2.13.15, 2.13.14 Apr 15, 2024
@SethTisue SethTisue added the internal not resulting in user-visible changes (build changes, tests, internal cleanups) label Apr 15, 2024
@SethTisue SethTisue merged commit fcf69c4 into scala:2.13.x Apr 15, 2024
3 checks passed
@som-snytt som-snytt deleted the test/fixup branch April 15, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal not resulting in user-visible changes (build changes, tests, internal cleanups)
Projects
None yet
3 participants