Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix scala task in our sbt build so REPL has JLine features again #10695

Merged
merged 1 commit into from Feb 21, 2024

Conversation

SethTisue
Copy link
Member

@SethTisue SethTisue commented Feb 21, 2024

fixes scala/scala-dev#755 (mostly, see remarks below)

references jline/jline3#884

mergeable for 2.13.13, and labeled "internal", because it doesn't affect end users, only contributors

@SethTisue SethTisue added tool:REPL Changes in the Scala REPL Interpreter internal not resulting in user-visible changes (build changes, tests, internal cleanups) labels Feb 21, 2024
@SethTisue SethTisue self-assigned this Feb 21, 2024
@scala-jenkins scala-jenkins added this to the 2.13.14 milestone Feb 21, 2024
@SethTisue SethTisue modified the milestones: 2.13.14, 2.13.13 Feb 21, 2024
@SethTisue
Copy link
Member Author

I noticed just now that although this improves the situation substantially, paren and brace matching is messed up — when you type the closing brace, both braces disappear :-/

This is mergeable regardless, though.

@SethTisue SethTisue merged commit fcc67cd into scala:2.13.x Feb 21, 2024
3 checks passed
@SethTisue SethTisue deleted the scala-dev-755 branch February 21, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal not resulting in user-visible changes (build changes, tests, internal cleanups) tool:REPL Changes in the Scala REPL Interpreter
Projects
None yet
2 participants