Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak HashSet tests #10686

Merged
merged 1 commit into from Feb 12, 2024
Merged

Tweak HashSet tests #10686

merged 1 commit into from Feb 12, 2024

Conversation

som-snytt
Copy link
Contributor

@som-snytt som-snytt commented Feb 8, 2024 •
edited

Moves the original subsetOf test to HashSetTest. Prefer assertTrue to require.

See the nice rklaehn comments at https://github.com/scala/scala/pull/3315/files

Missed the train at #10683 just as the doors were closing.

@scala-jenkins scala-jenkins added this to the 2.13.14 milestone Feb 8, 2024
@som-snytt som-snytt added the internal not resulting in user-visible changes (build changes, tests, internal cleanups) label Feb 8, 2024
@SethTisue SethTisue modified the milestones: 2.13.14, 2.13.13 Feb 8, 2024
@SethTisue SethTisue requested a review from a team February 8, 2024 19:24
@SethTisue SethTisue added the library:collections PRs involving changes to the standard collection library label Feb 8, 2024
@SethTisue SethTisue merged commit 17c0c74 into scala:2.13.x Feb 12, 2024
3 checks passed
@som-snytt som-snytt deleted the tweak/12944-hashset-issubset branch February 12, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
internal not resulting in user-visible changes (build changes, tests, internal cleanups) library:collections PRs involving changes to the standard collection library
Projects
None yet
Milestone
2.13.13
3 participants
@som-snytt @SethTisue @scala-jenkins