Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish for Scala 2.13.0-M5 #256

Closed
SethTisue opened this issue Aug 30, 2018 · 11 comments
Closed

publish for Scala 2.13.0-M5 #256

SethTisue opened this issue Aug 30, 2018 · 11 comments

Comments

@SethTisue
Copy link
Member

No description provided.

@SethTisue
Copy link
Member Author

probably blocked for now by scala-js/scala-js#3443 ?

@SethTisue
Copy link
Member Author

SethTisue commented Sep 11, 2018

"Scala.js 0.6.25 is now released with support for Scala 2.13.0-M5"

@ashawley is anything blocking us here? do you expect to get to this soon, like in the next couple days, say... or would you like the Scala team to handle it this time...? either way's totally fine

@SethTisue
Copy link
Member Author

SethTisue commented Sep 11, 2018

if the answer is "we're blocked by scala/sbt-scala-module#41", gah, what a mess, it seems there are multiple possible ways forward there and I've gotten lost in all the options

in this repo, at #217, for M4 it looks like we didn't need to completely sort this out, we are able to publish anyway

for M5, can we do like we did for M4 and just push a tag like v1.1.0#2.13.0-M5#8 (after including any M5 changes). yes? or am I missing something?

@ashawley
Copy link
Member

I updated my collectionsBootstrap branch, and got it to compile on M5. I was just waiting on Scala.js, but it sounds like that's ready now. I'll try to work on getting it publishing in the next few days.

Indeed, we were able to publish 2.13.0-M4 as you describe. The Java 6 failures won't keep us from publishing 2.13.0-M5.

@ashawley
Copy link
Member

ashawley commented Sep 14, 2018

I pushed a new tag v1.1.0#2.13.0-M5#8 and it looks like it published to sonatype.

I've updated the newCollectionBootstrap. However, it is broken because of:

Previously, #217.

@SethTisue
Copy link
Member Author

SethTisue commented Sep 14, 2018

@ashawley looking at https://travis-ci.org/scala/scala-xml/builds/428459277 and at the staging repos on Sonatype, it looks like you hit the same problem I did at scala/scala-parser-combinators#170, where the Travis job for JDK 6 (https://travis-ci.org/scala/scala-xml/jobs/428459278) actually ran on JDK 8, so artifacts got staged twice. there are two staging repos, orgscala-lang-1607 and orgscala-lang-1608, that both contain similar (possibly identical?) artifacts

I think you need to do the equivalent of scala/scala-parser-combinators#156 here. (or if we already did that here but in some other branch, cherry-pick the change)

wdyt, should I just pick one of the two staging repos (1607 and 1608) and release it, or should we redo this, like I did for scala-parser-combinators?

@ashawley
Copy link
Member

I'm familiar with the issue, it was #246 here.

Sounds like we have two identical JDK 8 artifacts, but I don't know for sure.

Should I just cherry-pick and force-push the tag?

@SethTisue
Copy link
Member Author

that seems like the safest course

(well, I'm not actually sure if "force-push the tag" has the same or different effects than deleting it (first push) and then re-creating it (second push), which is what I did on scala-parser-combinators)

@ashawley
Copy link
Member

Yeah, forcing the tag, then force-push the tag again should have worked. Can you look again? Should just have one set of artifacts this time.

@SethTisue
Copy link
Member Author

SethTisue commented Sep 14, 2018

I dropped orgscala-lang-1607 and orgscala-lang-1608 via the Sonatype web UI

and also closed and released orgscala-lang-1609 and orgscala-lang-1610 (as usual it's unpredictable how many staging repos you end up with, in this case the JVM artifacts were in one and the JS artifacts in the other)

so let's keep an eye on https://repo1.maven.org/maven2/org/scala-lang/modules/scala-xml_2.13.0-M5/1.1.0/

@ashawley ashawley mentioned this issue Sep 14, 2018
2 tasks
@SethTisue
Copy link
Member Author

happy little artifacts

screen shot 2018-09-14 at 4 59 57 pm

Welcome to Scala 2.13.0-M5 (Java HotSpot(TM) 64-Bit Server VM, Java 1.8.0_181).
Type in expressions for evaluation. Or try :help.

scala> <foo/>
res0: scala.xml.Elem = <foo/>

scala/make-release-notes@17fb353

thanks Aaron!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants