Fix OOM for ConstructingParser #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shorten test names and minimize string literals.
Add eof checks to: - MarkupParser.xEntityValue - MarkupParser.xComment - MarkupParser.systemLiteral - MarkupParser.pubidLiteral - MarkupParser.notationDecl - MarkupParserCommon.xAttributeValue - MarkupParserCommon.xTakeUntil
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to fix the long-standing defects in
ConstructingParserthat were shown to cause out of memory exceptions. The original tests contributed by Artem Stasiuk in #32 presumed fixing the methods would make them throw exceptions. I made a more minimal fix: I followed the suggestions of A.P. Marki that not every syntax error is fatal, and that it is better to address the infinite loops in various method than actually terminate processing with an exception. Admittedly, this code is pretty inconsistent with respect to termination. I suggest we take that on later.To be honest, making further improvements would have consequences in the behavior of
XMLEventReader. I decided to not go there. There is a plan to dropXMLEventReaderin #200. Given, my most recent experience here, I'd say that's still a good idea.