Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handle filesystem importers when load paths aren't necessary #2203

Merged
merged 7 commits into from Mar 27, 2024
Merged

Better handle filesystem importers when load paths aren't necessary #2203

merged 7 commits into from Mar 27, 2024

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Mar 21, 2024

@nex3 nex3 requested a review from jathak March 21, 2024 23:46
@nex3 nex3 mentioned this pull request Mar 21, 2024
Open
2 tasks
jathak
jathak approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@jathak jathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sass-spec needs to be updated with the new deprecation warnings

lib/src/deprecation.dart Outdated Show resolved Hide resolved
nex3 added a commit that referenced this pull request Mar 22, 2024
@nex3
Add a regressoin test for #2203
7da9624
jathak
jathak approved these changes Mar 22, 2024
View reviewed changes
lib/src/importer/filesystem.dart Outdated Show resolved Hide resolved
@nex3 nex3 merged commit c8d0643 into main Mar 27, 2024
34 checks passed
@nex3 nex3 deleted the fs-importer branch March 27, 2024 18:03
@ntkme ntkme mentioned this pull request Apr 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jathak jathak jathak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nex3 @jathak