Fix linux musl builds #2175
Merged
Fix linux musl builds #2175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ntkme
commented
Feb 16, 2024
ntkme
commented
- Closes linux-musl 1.71.0 release builds are broken #2174
|
I noticed that this is a potential breaking change for downloading script in embedded-host-node: https://github.com/sass/embedded-host-node/blob/6944074bb227660883253d2c57183301dd1bd1d6/tool/prepare-optional-release.ts#L172-L179 This is because we used to have @nex3 Shall we change cli_pkg or the download script in embedded-host-node? |
|
I think we should fix it in the embedded host (which it looks like your PR already does), at least partly because changing |
nex3
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.