Add wait time before update website #2153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nex3
approved these changes
Dec 29, 2023
|
Thanks! |
jgerigmeyer
added a commit
to oddbird/dart-sass
that referenced
this pull request
Jan 8, 2024
* main: Update the pubspec and changelog for sass/embedded-host-node#266 (sass#2158) Add wait time before update website (sass#2153) Make meta.apply() an AsyncBuiltInCallable (sass#2152) Upload releases for musl-libc and android (sass#2149) Escape unprintable 0x7F (delete control character) (sass#2144) Bump dartdoc from 7.0.2 to 8.0.2 (sass#2146)
lmeysel
pushed a commit
to lmeysel/dart-sass
that referenced
this pull request
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have hit this issue multiple times in the past. While there is a few reports of the same kind of delay, there isn't much technical explanation available.
According to a super old npm blog article from 2014:
The delay is likely that the time taken for each CDN node to replicate the CouchDB metadata containing the package list, and it can take up to minutes. Therefore this PR goes conservative and adds 10 minutes delay before we update the website, trying to minimize chance of failure.
cc @nex3