Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shared Resources] dart-sass implementation #2134

Merged
merged 13 commits into from
Jan 18, 2024

Conversation

jerivas
Copy link
Contributor

@jerivas jerivas commented Nov 21, 2023

Issue

Blocked until proposal is accepted.

In dart-sass the compiler classes are just thin wrappers around the compile* functions because there is no underlying compiler process

[skip sass-embedded]

@jerivas
Copy link
Contributor Author

jerivas commented Nov 22, 2023

@jerivas jerivas requested a review from nex3 November 22, 2023 00:52
lib/src/js/compiler.dart Outdated Show resolved Hide resolved
lib/src/js/compiler.dart Show resolved Hide resolved
lib/src/js/compiler.dart Show resolved Hide resolved
lib/src/js/compiler.dart Outdated Show resolved Hide resolved
lib/src/js/compiler.dart Outdated Show resolved Hide resolved
lib/src/js/compiler.dart Outdated Show resolved Hide resolved
Copy link
Contributor

@jamesnw jamesnw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nex3 I've made most of the requested changes, but have some questions that could use your input.

lib/src/js/compiler.dart Outdated Show resolved Hide resolved
lib/src/js/compiler.dart Outdated Show resolved Hide resolved
lib/src/js/compiler.dart Show resolved Hide resolved
lib/src/js/compiler.dart Show resolved Hide resolved
@jamesnw jamesnw requested a review from nex3 December 12, 2023 17:06
lib/src/js/compiler.dart Outdated Show resolved Hide resolved
lib/src/js/compiler.dart Show resolved Hide resolved
lib/src/js/compiler.dart Outdated Show resolved Hide resolved
lib/src/js/compiler.dart Outdated Show resolved Hide resolved
lib/src/js/compiler.dart Outdated Show resolved Hide resolved
lib/src/js/compiler.dart Outdated Show resolved Hide resolved
@jamesnw jamesnw requested a review from nex3 December 21, 2023 16:49
* main:
  Update the pubspec and changelog for sass/embedded-host-node#266 (sass#2158)
  Add wait time before update website (sass#2153)
  Make meta.apply() an AsyncBuiltInCallable (sass#2152)
  Upload releases for musl-libc and android (sass#2149)
  Escape unprintable 0x7F (delete control character) (sass#2144)
  Bump dartdoc from 7.0.2 to 8.0.2 (sass#2146)
@nex3 nex3 merged commit 076414d into sass:main Jan 18, 2024
29 checks passed
@nex3 nex3 deleted the feature.shared-resources branch January 18, 2024 02:48
lmeysel pushed a commit to lmeysel/dart-sass that referenced this pull request Feb 20, 2024
Co-authored-by: James Stuckey Weber <jamesnw@gmail.com>
Co-authored-by: Jonny Gerig Meyer <jonny@oddbird.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants