[Package Importer] Dart Implementation #2130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 30, 2023
jamesnw
changed the title
jamesnw
commented
Oct 30, 2023
….package-importer
….package-importer
….package-importer
nex3
requested changes
Jan 19, 2024
nex3
requested changes
Jan 19, 2024
nex3
approved these changes
Jan 24, 2024
* main: Remove the sass dependency from package.json (sass#2162)
|
Our spec does not cover command line usage, but I think it would be useful to add a command line flag for dart-sass. E.g. We don't necessarily need to address this within this PR. It can be an enhancement at a later time. |
jamesnw
commented
Feb 1, 2024
6 tasks
nex3
requested changes
Feb 6, 2024
nex3
approved these changes
Feb 6, 2024
lmeysel
pushed a commit
to lmeysel/dart-sass
that referenced
this pull request
Feb 20, 2024
Co-authored-by: Jonny Gerig Meyer <jonny@oddbird.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sass/sass#2739
Blocked until proposal is accepted.
[skip sass-embedded]