Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut a release #2090

Merged
merged 3 commits into from
Sep 21, 2023
Merged

Cut a release #2090

merged 3 commits into from
Sep 21, 2023

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Sep 18, 2023

No description provided.

@ntkme
Copy link
Contributor

ntkme commented Sep 18, 2023

@nex3 Sass api version must be bumped as well. There is a check for that in the double check step:

for (var dir in [
".",
...Directory("pkg").listSync().map((entry) => entry.path)
]) {
var pubspec = Pubspec.parse(File("$dir/pubspec.yaml").readAsStringSync(),
sourceUrl: p.toUri("$dir/pubspec.yaml"));
var package = await client.packageInfo(pubspec.name);
if (pubspec.version == package.latestPubspec.version) {
fail("${pubspec.name} ${pubspec.version} has already been released!");
}
}

@nex3
Copy link
Contributor Author

nex3 commented Sep 19, 2023

@ntkme Good catch, I was thinking we'd already bumped it in one of the prior CLs.

pkg/sass_api/pubspec.yaml Outdated Show resolved Hide resolved
@ntkme
Copy link
Contributor

ntkme commented Sep 19, 2023

Another missing item here is that we need to cut a release for embedded protocol before release dart-sass.

@nex3
Copy link
Contributor Author

nex3 commented Sep 20, 2023

Thanks @ntkme! Included the protocol version bump in sass/sass#3693.

@nex3 nex3 merged commit 873e91e into main Sep 21, 2023
44 checks passed
@nex3 nex3 deleted the release branch September 21, 2023 00:18
jgerigmeyer added a commit to oddbird/dart-sass that referenced this pull request Oct 12, 2023
* feature.color-4: (30 commits)
  Update for `lch()` tests (sass#2108)
  Add support for relative color syntax (sass#2112)
  Update for `oklab()` tests (sass#2094)
  Poke CI
  Cut a release (sass#2107)
  Implement first class mixins (sass#2073)
  Fix a race condition preventing embedded compiler to shutdown after a protocol error (sass#2106)
  Switch to the GitHub-hosted MacOS ARM64 runner (sass#2103)
  Update the version of Sass used by the website on release (sass#2102)
  Bump actions/checkout from 3 to 4 (sass#2088)
  Bump docker/setup-qemu-action from 2 to 3 (sass#2089)
  Implement support for the relative color syntax of CSS Color 5 (sass#2098)
  Rephrase errors for numbers that must be unitless or % (sass#2101)
  Forbid LLM contributions (sass#2100)
  Update protocol-version during embedded-host-node release (sass#2097)
  Deprecate Deprecation.calcInterp (sass#2096)
  Avoid useless allocations for interpolations without maps (sass#2095)
  Fix an error during embedded compiler shutdown (sass#2092)
  Cut a release (sass#2090)
  Expose the containing URL to importers under some circumstances (sass#2083)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants