Calc functions implementation #1970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamelalozano16
commented
May 19, 2023
Goodwine
requested changes
May 19, 2023
There was a problem hiding this comment.
In your PR description, add a link to the corresponding sass-spec PR. That way the CI pipeline will run the tests against your other PR rather than HEAD
E.g. add:
Tests: https://github.com/sass/sass-spec/pull/1912
The format is not important IIRC, as long as you have a link to the PR it should work.
pamelalozano16
force-pushed
the
pamelalozano
branch
3 times, most recently
from
ce38d29
to
68b60a3
Compare
pamelalozano16
force-pushed
the
pamelalozano
branch
from
68b60a3
to
e3e91d7
Compare
Goodwine
requested changes
May 19, 2023
There was a problem hiding this comment.
I think the CI errors are complaining because you must generate the "synchronized" file. The async_evaluate.dart file has a non-async counterpart (eveluate.dart) that is autogenerated.
You can run dart run grinder synchronize to generate it. Then you can add it to this PR
pamelalozano16
force-pushed
the
pamelalozano
branch
from
e3e91d7
to
78f593e
Compare
jathak
reviewed
May 19, 2023
pamelalozano16
force-pushed
the
pamelalozano
branch
2 times, most recently
from
f86fc49
to
a0eace6
Compare
pamelalozano16
changed the title
pamelalozano16
force-pushed
the
pamelalozano
branch
5 times, most recently
from
4373794
to
885dfc7
Compare
jathak
reviewed
May 24, 2023
jathak
reviewed
May 24, 2023
pamelalozano16
force-pushed
the
pamelalozano
branch
6 times, most recently
from
acfdde9
to
b9b9602
Compare
pamelalozano16
force-pushed
the
pamelalozano
branch
2 times, most recently
from
12fbaa4
to
6f963c4
Compare
pamelalozano16
force-pushed
the
pamelalozano
branch
from
6f963c4
to
8fdd53e
Compare
14 tasks
pamelalozano16
force-pushed
the
pamelalozano
branch
from
510ee08
to
b1625bd
Compare
pamelalozano16
force-pushed
the
pamelalozano
branch
2 times, most recently
from
5048f83
to
9f3341e
Compare
Goodwine
reviewed
Aug 9, 2023
pamelalozano16
force-pushed
the
pamelalozano
branch
from
9f3341e
to
49088f0
Compare
Goodwine
approved these changes
Aug 9, 2023
Goodwine
reviewed
Aug 9, 2023
pubspec.yaml
Outdated
| @@ -1,5 +1,5 @@ | |||
| name: sass | |||
| version: 1.64.3 | |||
| version: 1.65.0-dev | |||
There was a problem hiding this comment.
We can release this now, please change the version to 1.65.0 without -dev. And then, modify the following 2 files:
pkg/sass_api/pubspec.yaml- Update the Sass version to
sass: 1.65.0 - Update the package version to
version: 8.1.0
- Update the Sass version to
pkg/sass_api/CHANGELOG.md- Add a new entry for version
8.1.0saying "No user-visible changes.", you can see other examples of this if you scroll down in the same file.
- Add a new entry for version
pamelalozano16
force-pushed
the
pamelalozano
branch
from
49088f0
to
16ca999
Compare
pamelalozano16
force-pushed
the
pamelalozano
branch
from
16ca999
to
9b1558a
Compare
Goodwine
approved these changes
Aug 9, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: Calc functions proposal
Tests: sass/sass-spec#1912