Use context.containing_url to track import stack #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major rewrite of importer wrapper to track import stack purely with
context.containing_url
(a feature added in dart-sass 1.68.0), instead of tracking our own stack with indirections via virtual sass files.Previously both single ImportResult and multi ImportResult arrays are handled with a virtual scss file for stack tracking. For a single ImportResult, it loads in three files: the first virtual file to "push" into the stack, the second actual file, and the third virtual file to "pop" out of the stack. Multi ImportResult arrays would generate an extra virtual sass file, in which each individual ImportResult loads three files the same way as single ImportResult.
Now single ImportResult is handled directly without having any virtual sass files.
This change has many benefits: