Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: make ESM properly load ESM endpoint and not masquerade as ESM #700

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

favna
Copy link
Member

@favna favna commented Dec 3, 2023

BREAKING CHANGE: This ensures that Framework will properly load the files from the dist/esm folder. This is BREAKING to ALL plugins that are not equally updated to load ESM specific files because they will otherwise load the CJS files of @sapphire/framework and every piece will load twice. DO NOT use this version without also updating your plugins! Sapphire plugins have been released alongside this version, third-party plugins will need to be updated by their respective authors!!

If you're curious btw, yes this long breaking change will show up properly in the changelog:

# [5.0.0](https://github.com/sapphiredev/framework/compare/v5.0.0...v5.0.0) - (2023-12-03)

## 🚀 Features

- Make ESM properly load ESM endpoint and not masquerade as ESM ([f900c2a](https://github.com/sapphiredev/framework/commit/f900c2abb54d1e9db3687d6ec0964d4629c5f31f))
  - 💥 **BREAKING CHANGE:** This ensures that Framework will properly load the files
from the dist/esm folder. This is BREAKING to ALL plugins that are not
equally updated to load ESM specific files because they will otherwise
load the CJS files of @sapphire/framework and every piece will load twice.
DO NOT use this version without also updating your plugins! Sapphire plugins
have been released alongside this version, third-party plugins will need
to be updated by their respective authors!!

ain't I good 😎

BREAKING CHANGE: This ensures that Framework will properly load the files
from the dist/esm folder. This is BREAKING to ALL plugins that are not
equally updated to load ESM specific files because they will otherwise
load the CJS files of @sapphire/framework and every piece will load twice.
DO NOT use this version without also updating your plugins! Sapphire plugins
have been released alongside this version, third-party plugins will need
to be updated by their respective authors!!
@favna favna requested a review from vladfrangu December 3, 2023 20:54
@favna favna self-assigned this Dec 3, 2023
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't even need my approval cuz you know I want this too but its a shame we have to do it in a major version

@favna favna marked this pull request as ready for review December 4, 2023 21:04
@favna favna merged commit 59b637e into main Dec 4, 2023
@favna favna deleted the refactor/esm-not-masquerading-as-esm branch December 4, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants