feat!: make ESM properly load ESM endpoint and not masquerade as ESM #700
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: This ensures that Framework will properly load the files from the dist/esm folder. This is BREAKING to ALL plugins that are not equally updated to load ESM specific files because they will otherwise load the CJS files of @sapphire/framework and every piece will load twice. DO NOT use this version without also updating your plugins! Sapphire plugins have been released alongside this version, third-party plugins will need to be updated by their respective authors!!
If you're curious btw, yes this long breaking change will show up properly in the changelog:
ain't I good 😎