Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move preconditions resolvers to dedicated files #679

Merged
merged 6 commits into from
Oct 23, 2023

Conversation

favna
Copy link
Member

@favna favna commented Oct 23, 2023

This gives sapphiredev/plugins#491 a better solution without as much code duplication. The methods parseConstructorPreConditionsNsfw, parseConstructorPreConditionsRunIn, parseConstructorPreConditionsRequiredClientPermissions, parseConstructorPreConditionsRequiredUserPermissions, and parseConstructorPreConditionsCooldown in the Command class are kept because otherwise, this would be a breaking change. I am still unsure if we want to deprecate those methods and remove them in a future major, then call the resolvers directly from parseConstructorPreConditions or not.

favna added 2 commits October 23, 2023 11:18

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
vladfrangu
vladfrangu previously approved these changes Oct 23, 2023
favna added 3 commits October 23, 2023 12:52

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@favna favna merged commit d9bbb28 into main Oct 23, 2023
@favna favna deleted the refactor/move-precondition-resolvers-to-dedicated-files branch October 23, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants