feat: make the Application Command Registries status listeners optional #627
+52
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sapphiredev pack |
|
Hey @favna, I've released this to NPM. You can install it for testing like so: npm install @sapphire/framework@pr-627 |
vladfrangu
requested changes
Apr 12, 2023
src/lib/utils/application-commands/ApplicationCommandRegistries.ts
Outdated
Show resolved
Hide resolved
vladfrangu
requested changes
Apr 12, 2023
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
vladfrangu
approved these changes
Apr 12, 2023
favna
deleted the
feat/make-application-command-registries-status-listeners-optional
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: on ready message - forum post
This PR addresses a few things:
loadApplicationCommandRegistriesStatusListenersEvents.ApplicationCommandRegistriesRegisteredcan now accept an (optional)timeTakenparameterApplicationCommandRegistries: Initializing...has been moved fromCoreReadytohandleRegistryAPICallsand is emitted to the new eventEvents.ApplicationCommandRegistriesInitialisingEvents.ApplicationCommandRegistriesRegisteredwas added that logs theApplicationCommandRegistries: Took ${diff.toLocaleString()}ms to initialize.)message