Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: SAP/component-operator-runtime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.3.84
Choose a base ref
...
head repository: SAP/component-operator-runtime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.3.85
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Mar 28, 2025

  1. update comments

    cbarbian-sap committed Mar 28, 2025
    Copy the full SHA
    128cb9c View commit details
Showing with 1 addition and 2 deletions.
  1. +1 −2 pkg/component/reconciler.go
3 changes: 1 addition & 2 deletions pkg/component/reconciler.go
Original file line number Diff line number Diff line change
@@ -275,7 +275,6 @@ func (r *Reconciler[T]) Reconcile(ctx context.Context, req ctrl.Request) (result
// all cases; the only exceptions are:
// - at the beginning, the state is set to Pending with condition FirstSeen
// - when the finalizer is set, the current state is preserved, and a requeue is triggered
// - at the end, after the finalizer is cleared, the state is preserved as well
switch status.State {
case StateReady:
// if getting here from processing state, then trigger one additional immediate reconcile iteration;
@@ -294,7 +293,7 @@ func (r *Reconciler[T]) Reconcile(ctx context.Context, req ctrl.Request) (result
status.SetState(StateError, ReadyConditionReasonTimeout, "Reconcilation of dependent resources timed out")
}
case StatePending, StateError:
// nothing to be done
// nothing to be done (see the remark before the switch above)
case StateDeletionPending, StateDeleting:
// because these states can only occur if deletionTimestamp is not zero
panic("this cannot happen")