-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(presentation): prevent openInStructure from linking to the presentation tool itself #1762
Merged
stipsan
merged 1 commit into
sanity-io:main
from
marcusforsberg:bugfix/open-in-structure
Jan 10, 2025
Merged
fix(presentation): prevent openInStructure from linking to the presentation tool itself #1762
stipsan
merged 1 commit into
sanity-io:main
from
marcusforsberg:bugfix/open-in-structure
Jan 10, 2025
+110
−187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@marcusforsberg is attempting to deploy a commit to the Sanity Sandbox Team on Vercel. A member of the Team first needs to authorize it. |
marcusforsberg
changed the title
fix(presentation): prevent openInStructure from from linking to the presentation tool itself
fix(presentation): prevent openInStructure from linking to the presentation tool itself
Aug 27, 2024
stipsan
previously approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! 💖
stipsan
force-pushed
the
bugfix/open-in-structure
branch
from
January 10, 2025 14:32
1378c36
to
2cd153b
Compare
Loading status checks…
…resentation tool itself
stipsan
force-pushed
the
bugfix/open-in-structure
branch
from
January 10, 2025 14:59
2cd153b
to
86903cf
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Sanity team! 👋
On some of our projects, the Presentation tool is the only tool used to work with content; i.e. there's no Structure tool at all.
In this scenario, the "Open in Structure" action will end up linking back to the Presentation tool itself, so nothing happens when you click on it.
Example screenshot below. Our Presentation tool is titled "Live Edit" and the action says "Open in Live Edit", but that tool is already open so the button effectively does nothing.
This PR solves that by excluding the Presentation tool when trying to find matches in
findStructureTool
. With this change, there's no action button shown at all, since there's no relevant tool to link to: