Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): fix the path of app-quickstart template #8976

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

binoy14
Copy link
Contributor

@binoy14 binoy14 commented Mar 18, 2025

Description

Renamed the template directory from core-app to app-quickstart since it uses the name in the templates to match to the directory

What to review

Verify you can create a new template

Testing

Tested by creating new applications using the renamed template and verifying that they initialize correctly with all expected files and functionality.

Verified

This commit was signed with the committer’s verified signature.
binoy14 Binoy Patel
Copy link

vercel bot commented Mar 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2025 5:23pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2025 5:23pm
studio-workshop 🔄 Building (Inspect) Visit Preview 💬 Add feedback Mar 18, 2025 5:23pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2025 5:23pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
test-next-studio ⬜️ Ignored (Inspect) Mar 18, 2025 5:23pm

Copy link
Contributor Author

binoy14 commented Mar 18, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@binoy14 binoy14 marked this pull request as ready for review March 18, 2025 17:18
@binoy14 binoy14 requested a review from a team as a code owner March 18, 2025 17:18
@binoy14 binoy14 requested review from pedrobonamin, juice49 and cngonzalez and removed request for a team March 18, 2025 17:18
Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 42.23% 55315 / 130963
🔵 Statements 42.23% 55315 / 130963
🔵 Functions 47.12% 2762 / 5861
🔵 Branches 79.2% 10307 / 13013
File CoverageNo changed files found.
Generated in workflow #32490 for commit e89cf0b by the Vitest Coverage Report Action

Copy link
Contributor

No changes to documentation

@binoy14 binoy14 merged commit 56c6cd2 into next Mar 18, 2025
52 of 60 checks passed
@binoy14 binoy14 deleted the 03-18-fix_cli_fix_the_path_of_app-quickstart_template branch March 18, 2025 17:25
Copy link
Contributor

⚡️ Editor Performance Report

Updated Tue, 18 Mar 2025 17:29:30 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 19.2 efps (52ms) 20.4 efps (49ms) -3ms (-5.8%)
article (body) 77.8 efps (13ms) 81.3 efps (12ms) -1ms (-/-%)
article (string inside object) 21.3 efps (47ms) 23.3 efps (43ms) -4ms (-8.5%)
article (string inside array) 18.9 efps (53ms) 21.1 efps (48ms) -6ms (-10.4%)
recipe (name) 43.5 efps (23ms) 29.0 efps (35ms) +12ms (+50.0%) 🔴
recipe (description) 45.5 efps (22ms) 31.7 efps (32ms) +10ms (+43.2%) 🔴
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (6ms) +1ms (-/-%)
synthetic (title) 18.7 efps (54ms) 19.2 efps (52ms) -2ms (-2.8%)
synthetic (string inside object) 18.9 efps (53ms) 19.8 efps (51ms) -3ms (-4.7%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 52ms 62ms 68ms 357ms 1501ms 11.8s
article (body) 13ms 15ms 18ms 141ms 79ms 5.1s
article (string inside object) 47ms 50ms 55ms 309ms 849ms 8.3s
article (string inside array) 53ms 55ms 68ms 301ms 1214ms 9.0s
recipe (name) 23ms 25ms 29ms 51ms 2ms 8.0s
recipe (description) 22ms 23ms 26ms 45ms 0ms 5.0s
recipe (instructions) 6ms 7ms 8ms 15ms 0ms 3.2s
synthetic (title) 54ms 56ms 59ms 218ms 838ms 13.5s
synthetic (string inside object) 53ms 56ms 59ms 220ms 929ms 8.1s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 49ms 71ms 86ms 450ms 1074ms 12.2s
article (body) 12ms 14ms 24ms 126ms 175ms 5.5s
article (string inside object) 43ms 46ms 50ms 194ms 399ms 7.3s
article (string inside array) 48ms 50ms 57ms 285ms 491ms 7.6s
recipe (name) 35ms 37ms 39ms 89ms 149ms 9.1s
recipe (description) 32ms 33ms 36ms 49ms 20ms 6.5s
recipe (instructions) 6ms 8ms 9ms 16ms 0ms 3.3s
synthetic (title) 52ms 57ms 69ms 339ms 978ms 13.1s
synthetic (string inside object) 51ms 52ms 59ms 172ms 396ms 8.0s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants