Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): updated background for the indicator #8971

Merged
merged 1 commit into from
Mar 18, 2025
Merged

Conversation

RitaDias
Copy link
Contributor

Description

Following the feedback from Marius

Before After
image image

What to review

The chance should speak for itself :)

Testing

N/A

Notes for release

N/A

Verified

This commit was signed with the committer’s verified signature.
mnecas Martin Nečas
Copy link

vercel bot commented Mar 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2025 10:21am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2025 10:21am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2025 10:21am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Mar 18, 2025 10:21am
test-next-studio ⬜️ Ignored (Inspect) Mar 18, 2025 10:21am

Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 42.16% 54661 / 129646
🔵 Statements 42.16% 54661 / 129646
🔵 Functions 47.09% 2741 / 5820
🔵 Branches 79.4% 10223 / 12874
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/sanity/src/core/perspective/navbar/PerspectiveLayerIndicator.tsx 100% 100% 100% 100%
Generated in workflow #32465 for commit 87ecb9f by the Vitest Coverage Report Action

Copy link
Contributor

No changes to documentation

Copy link
Contributor

⚡️ Editor Performance Report

Updated Tue, 18 Mar 2025 10:33:59 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 25.0 efps (40ms) 26.3 efps (38ms) -2ms (-5.0%)
article (body) 72.5 efps (14ms) 77.8 efps (13ms) -1ms (-/-%)
article (string inside object) 25.0 efps (40ms) 26.7 efps (38ms) -3ms (-6.3%)
article (string inside array) 23.3 efps (43ms) 23.8 efps (42ms) -1ms (-2.3%)
recipe (name) 58.8 efps (17ms) 48.8 efps (21ms) +4ms (+20.6%) 🔴
recipe (description) 58.8 efps (17ms) 55.6 efps (18ms) +1ms (+5.9%)
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (5ms) +0ms (-/-%)
synthetic (title) 18.5 efps (54ms) 20.0 efps (50ms) -4ms (-7.4%)
synthetic (string inside object) 19.8 efps (51ms) 20.8 efps (48ms) -3ms (-5.0%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 40ms 45ms 68ms 346ms 672ms 11.0s
article (body) 14ms 15ms 19ms 105ms 59ms 4.9s
article (string inside object) 40ms 43ms 47ms 261ms 239ms 7.2s
article (string inside array) 43ms 46ms 51ms 201ms 195ms 7.2s
recipe (name) 17ms 18ms 21ms 33ms 0ms 6.5s
recipe (description) 17ms 19ms 22ms 27ms 0ms 4.1s
recipe (instructions) 5ms 6ms 7ms 8ms 0ms 3.0s
synthetic (title) 54ms 57ms 60ms 237ms 853ms 13.3s
synthetic (string inside object) 51ms 54ms 63ms 96ms 843ms 8.1s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 38ms 41ms 47ms 257ms 366ms 9.8s
article (body) 13ms 14ms 17ms 160ms 165ms 5.2s
article (string inside object) 38ms 41ms 44ms 148ms 139ms 7.0s
article (string inside array) 42ms 45ms 48ms 275ms 403ms 7.5s
recipe (name) 21ms 23ms 25ms 41ms 0ms 7.3s
recipe (description) 18ms 20ms 20ms 29ms 0ms 4.6s
recipe (instructions) 5ms 6ms 7ms 12ms 0ms 3.0s
synthetic (title) 50ms 54ms 59ms 223ms 1001ms 12.5s
synthetic (string inside object) 48ms 51ms 63ms 248ms 569ms 8.0s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@RitaDias RitaDias marked this pull request as ready for review March 18, 2025 12:27
@RitaDias RitaDias requested a review from a team as a code owner March 18, 2025 12:27
@RitaDias RitaDias requested review from rexxars, a team and juice49 and removed request for a team and rexxars March 18, 2025 12:27
@RitaDias RitaDias merged commit 044f3c1 into next Mar 18, 2025
60 checks passed
@RitaDias RitaDias deleted the sapp-2413 branch March 18, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants