Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(structure): some touches to version chips #8933

Merged
merged 2 commits into from
Mar 14, 2025
Merged

Conversation

pedrobonamin
Copy link
Contributor

@pedrobonamin pedrobonamin commented Mar 14, 2025

Description

Changes the borders for the version chips.
Removes the background for disabled chips and instead uses muted colors.

Last updates:
Screenshot 2025-03-14 at 13 33 13
Screenshot 2025-03-14 at 13 37 31

What to review

Testing

Notes for release

@pedrobonamin pedrobonamin requested a review from a team as a code owner March 14, 2025 10:52
@pedrobonamin pedrobonamin requested review from RitaDias and removed request for a team March 14, 2025 10:52
Copy link

vercel bot commented Mar 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2025 0:48am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2025 0:48am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2025 0:48am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Mar 14, 2025 0:48am
test-next-studio ⬜️ Ignored (Inspect) Mar 14, 2025 0:48am

RitaDias
RitaDias previously approved these changes Mar 14, 2025
Copy link
Contributor

@RitaDias RitaDias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Mar 14, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 42.07% 54503 / 129553
🔵 Statements 42.07% 54503 / 129553
🔵 Functions 47% 2737 / 5823
🔵 Branches 79.42% 10205 / 12849
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/sanity/src/core/releases/components/ReleaseAvatar.tsx 100% 83.33% 100% 100%
packages/sanity/src/core/releases/components/documentHeader/VersionChip.tsx 74.66% 37.5% 15.38% 74.66% 112-114, 119-120, 129-130, 138, 149-159, 169-182, 239-246, 251-261
Generated in workflow #32342 for commit c218542 by the Vitest Coverage Report Action

Copy link
Contributor

github-actions bot commented Mar 14, 2025

⚡️ Editor Performance Report

Updated Fri, 14 Mar 2025 13:03:28 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 22.7 efps (44ms) 21.1 efps (48ms) +4ms (+8.0%)
article (body) 63.5 efps (16ms) 67.8 efps (15ms) -1ms (-/-%)
article (string inside object) 23.5 efps (43ms) 24.4 efps (41ms) -2ms (-3.5%)
article (string inside array) 21.5 efps (47ms) 20.8 efps (48ms) +2ms (+3.2%)
recipe (name) 44.4 efps (23ms) 43.5 efps (23ms) +1ms (+2.2%)
recipe (description) 47.6 efps (21ms) 47.6 efps (21ms) +0ms (-/-%)
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (6ms) +0ms (-/-%)
synthetic (title) 19.6 efps (51ms) 18.9 efps (53ms) +2ms (+3.9%)
synthetic (string inside object) 19.6 efps (51ms) 19.4 efps (52ms) +1ms (+1.0%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 44ms 51ms 73ms 304ms 531ms 11.3s
article (body) 16ms 18ms 26ms 155ms 401ms 6.0s
article (string inside object) 43ms 45ms 51ms 281ms 399ms 7.7s
article (string inside array) 47ms 50ms 52ms 232ms 390ms 7.7s
recipe (name) 23ms 25ms 26ms 39ms 5ms 7.3s
recipe (description) 21ms 23ms 25ms 42ms 6ms 4.9s
recipe (instructions) 6ms 7ms 8ms 10ms 0ms 3.2s
synthetic (title) 51ms 57ms 62ms 312ms 884ms 13.0s
synthetic (string inside object) 51ms 54ms 58ms 183ms 853ms 8.0s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 48ms 69ms 80ms 327ms 716ms 13.1s
article (body) 15ms 16ms 17ms 131ms 170ms 5.6s
article (string inside object) 41ms 43ms 45ms 59ms 85ms 6.9s
article (string inside array) 48ms 50ms 51ms 145ms 301ms 7.3s
recipe (name) 23ms 25ms 29ms 44ms 0ms 7.5s
recipe (description) 21ms 22ms 28ms 41ms 0ms 5.0s
recipe (instructions) 6ms 7ms 10ms 21ms 0ms 3.3s
synthetic (title) 53ms 58ms 70ms 354ms 1150ms 13.7s
synthetic (string inside object) 52ms 55ms 64ms 236ms 840ms 8.2s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor

@RitaDias RitaDias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants