Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): reduce new releases and timezone buttons size #8931

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

pedrobonamin
Copy link
Contributor

Description

Updates the padding and spacing for new releases and timezone button.

Before After
Screenshot 2025-03-14 at 10 21 57 Screenshot 2025-03-14 at 10 22 09

What to review

Does it looks good?

Testing

Notes for release

@pedrobonamin pedrobonamin requested a review from a team as a code owner March 14, 2025 09:23
@pedrobonamin pedrobonamin requested review from juice49 and removed request for a team March 14, 2025 09:23
Copy link

vercel bot commented Mar 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2025 2:27pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2025 2:27pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2025 2:27pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Mar 14, 2025 2:27pm
test-next-studio ⬜️ Ignored (Inspect) Mar 14, 2025 2:27pm

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Mar 14, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 42.2% 54658 / 129515
🔵 Statements 42.2% 54658 / 129515
🔵 Functions 47.08% 2740 / 5819
🔵 Branches 79.37% 10215 / 12870
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/sanity/src/core/releases/tool/overview/ReleasesOverview.tsx 95.1% 84.88% 80% 95.1% 88, 131-132, 150, 166, 235-239, 272-274, 281-285
Generated in workflow #32363 for commit 5d2859d by the Vitest Coverage Report Action

Copy link
Contributor

github-actions bot commented Mar 14, 2025

⚡️ Editor Performance Report

Updated Fri, 14 Mar 2025 14:34:08 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 25.6 efps (39ms) 26.3 efps (38ms) -1ms (-2.6%)
article (body) 77.5 efps (13ms) 78.7 efps (13ms) -0ms (-/-%)
article (string inside object) 26.3 efps (38ms) 25.6 efps (39ms) +1ms (+2.6%)
article (string inside array) 23.3 efps (43ms) 24.1 efps (42ms) -2ms (-3.5%)
recipe (name) 45.5 efps (22ms) 45.5 efps (22ms) +0ms (-/-%)
recipe (description) 50.0 efps (20ms) 50.0 efps (20ms) +0ms (-/-%)
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (5ms) +0ms (-/-%)
synthetic (title) 18.5 efps (54ms) 17.9 efps (56ms) +2ms (+3.7%)
synthetic (string inside object) 19.6 efps (51ms) 19.6 efps (51ms) +0ms (-/-%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 39ms 42ms 50ms 305ms 459ms 10.7s
article (body) 13ms 16ms 19ms 57ms 45ms 5.2s
article (string inside object) 38ms 41ms 45ms 77ms 133ms 6.8s
article (string inside array) 43ms 45ms 48ms 140ms 146ms 7.0s
recipe (name) 22ms 25ms 29ms 44ms 1ms 7.1s
recipe (description) 20ms 21ms 24ms 43ms 0ms 4.8s
recipe (instructions) 5ms 7ms 9ms 22ms 0ms 3.3s
synthetic (title) 54ms 58ms 66ms 216ms 1144ms 13.0s
synthetic (string inside object) 51ms 53ms 59ms 387ms 1056ms 8.3s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 38ms 41ms 48ms 267ms 409ms 10.2s
article (body) 13ms 14ms 17ms 53ms 53ms 4.7s
article (string inside object) 39ms 43ms 54ms 153ms 282ms 7.6s
article (string inside array) 42ms 44ms 46ms 56ms 167ms 7.0s
recipe (name) 22ms 25ms 28ms 44ms 9ms 7.3s
recipe (description) 20ms 21ms 25ms 44ms 5ms 4.9s
recipe (instructions) 5ms 7ms 8ms 10ms 0ms 3.1s
synthetic (title) 56ms 58ms 65ms 456ms 974ms 13.1s
synthetic (string inside object) 51ms 54ms 60ms 272ms 866ms 8.4s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

jordanl17
jordanl17 previously approved these changes Mar 14, 2025
Copy link
Member

@jordanl17 jordanl17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks 🌶️

@pedrobonamin pedrobonamin merged commit ee72551 into next Mar 17, 2025
60 checks passed
@pedrobonamin pedrobonamin deleted the sapp-2412 branch March 17, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants