Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): hide scheduled releases in copy version to menu #8929

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

pedrobonamin
Copy link
Contributor

Description

Hides "locked" scheduled releases in copy version to menu

Before After
Screenshot 2025-03-14 at 10 04 57 Screenshot 2025-03-14 at 10 05 19

What to review

Testing

Not much

Notes for release

Hides "locked" scheduled releases in copy version to menu

@pedrobonamin pedrobonamin requested a review from a team as a code owner March 14, 2025 09:06
@pedrobonamin pedrobonamin requested review from RitaDias and removed request for a team March 14, 2025 09:06
Copy link

vercel bot commented Mar 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2025 9:10am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2025 9:10am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2025 9:10am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Mar 14, 2025 9:10am
test-next-studio ⬜️ Ignored (Inspect) Mar 14, 2025 9:10am

@@ -51,9 +51,7 @@ export const VersionContextMenu = memo(function VersionContextMenu(props: {
const {t} = useTranslation()
const {mode} = useReleasesUpsell()
const isPublished = isPublishedId(documentId) && !isVersion
const optionsReleaseList = releases.map((release) => ({
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't find the reason for this map, was there any?

Copy link
Contributor

@RitaDias RitaDias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡🚀

Copy link
Contributor

No changes to documentation

Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 42.01% 54443 / 129586
🔵 Statements 42.01% 54443 / 129586
🔵 Functions 46.89% 2729 / 5820
🔵 Branches 79.39% 10195 / 12841
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/sanity/src/core/releases/components/documentHeader/contextMenu/VersionContextMenu.tsx 100% 91.07% 100% 100%
Generated in workflow #32297 for commit 7d114a8 by the Vitest Coverage Report Action

Copy link
Contributor

⚡️ Editor Performance Report

Updated Fri, 14 Mar 2025 09:21:18 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 22.7 efps (44ms) 23.8 efps (42ms) -2ms (-4.5%)
article (body) 72.5 efps (14ms) 73.0 efps (14ms) -0ms (-/-%)
article (string inside object) 27.0 efps (37ms) 23.8 efps (42ms) +5ms (+13.5%)
article (string inside array) 23.3 efps (43ms) 21.7 efps (46ms) +3ms (+7.0%)
recipe (name) 45.5 efps (22ms) 43.5 efps (23ms) +1ms (+4.5%)
recipe (description) 47.6 efps (21ms) 50.0 efps (20ms) -1ms (-4.8%)
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (6ms) +1ms (-/-%)
synthetic (title) 17.5 efps (57ms) 20.0 efps (50ms) -7ms (-12.3%)
synthetic (string inside object) 17.7 efps (57ms) 19.6 efps (51ms) -6ms (-9.7%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 44ms 48ms 56ms 170ms 239ms 10.6s
article (body) 14ms 16ms 27ms 168ms 246ms 5.5s
article (string inside object) 37ms 39ms 42ms 144ms 230ms 6.8s
article (string inside array) 43ms 45ms 50ms 220ms 282ms 7.2s
recipe (name) 22ms 23ms 26ms 53ms 8ms 7.8s
recipe (description) 21ms 23ms 26ms 41ms 0ms 4.9s
recipe (instructions) 5ms 6ms 8ms 12ms 0ms 3.3s
synthetic (title) 57ms 62ms 67ms 337ms 1123ms 14.4s
synthetic (string inside object) 57ms 63ms 73ms 97ms 1173ms 8.8s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 42ms 49ms 71ms 306ms 532ms 16.4s
article (body) 14ms 15ms 21ms 359ms 529ms 5.6s
article (string inside object) 42ms 44ms 51ms 63ms 266ms 7.3s
article (string inside array) 46ms 49ms 59ms 95ms 485ms 7.9s
recipe (name) 23ms 25ms 29ms 57ms 5ms 8.3s
recipe (description) 20ms 21ms 22ms 28ms 0ms 5.2s
recipe (instructions) 6ms 9ms 10ms 36ms 7ms 3.4s
synthetic (title) 50ms 55ms 70ms 317ms 868ms 15.4s
synthetic (string inside object) 51ms 53ms 58ms 243ms 693ms 7.8s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@pedrobonamin pedrobonamin merged commit ea10caf into next Mar 14, 2025
60 checks passed
@pedrobonamin pedrobonamin deleted the sapp-2467 branch March 14, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants