Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(releases): add unit tests for createReleaseMetadataAggregator and useActiveReleases hooks #8926

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

jordanl17
Copy link
Member

@jordanl17 jordanl17 commented Mar 13, 2025

Description

Some more tests to fill in gaps around the releases store and hooks

What to review

Testing

This is just tests

Notes for release

N/A

Copy link

vercel bot commented Mar 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2025 10:41am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2025 10:41am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2025 10:41am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Mar 14, 2025 10:41am
test-next-studio ⬜️ Ignored (Inspect) Mar 14, 2025 10:41am

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Mar 13, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 42.08% 54532 / 129588
🔵 Statements 42.08% 54532 / 129588
🔵 Functions 46.98% 2736 / 5823
🔵 Branches 79.46% 10233 / 12878
File CoverageNo changed files found.
Generated in workflow #32314 for commit c07e66c by the Vitest Coverage Report Action

Copy link
Contributor

github-actions bot commented Mar 13, 2025

⚡️ Editor Performance Report

Updated Fri, 14 Mar 2025 10:46:03 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 26.0 efps (39ms) 25.6 efps (39ms) +1ms (+1.3%)
article (body) 78.1 efps (13ms) 77.8 efps (13ms) +0ms (-/-%)
article (string inside object) 27.0 efps (37ms) 27.0 efps (37ms) +0ms (-/-%)
article (string inside array) 23.3 efps (43ms) 24.4 efps (41ms) -2ms (-4.7%)
recipe (name) 31.3 efps (32ms) 47.6 efps (21ms) -11ms (-34.4%)
recipe (description) 33.3 efps (30ms) 51.3 efps (20ms) -11ms (-35.0%)
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (5ms) +0ms (-/-%)
synthetic (title) 18.9 efps (53ms) 19.2 efps (52ms) -1ms (-1.9%)
synthetic (string inside object) 20.4 efps (49ms) 20.4 efps (49ms) +0ms (-/-%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 39ms 42ms 45ms 310ms 31ms 10.7s
article (body) 13ms 14ms 15ms 48ms 55ms 4.8s
article (string inside object) 37ms 41ms 46ms 194ms 253ms 6.8s
article (string inside array) 43ms 44ms 49ms 171ms 192ms 7.1s
recipe (name) 32ms 35ms 39ms 53ms 130ms 9.4s
recipe (description) 30ms 32ms 32ms 35ms 4ms 6.2s
recipe (instructions) 5ms 7ms 9ms 35ms 0ms 3.2s
synthetic (title) 53ms 56ms 62ms 231ms 919ms 13.0s
synthetic (string inside object) 49ms 51ms 62ms 223ms 528ms 8.3s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 39ms 43ms 64ms 329ms 496ms 10.4s
article (body) 13ms 14ms 16ms 43ms 44ms 4.8s
article (string inside object) 37ms 38ms 42ms 117ms 37ms 6.4s
article (string inside array) 41ms 42ms 45ms 226ms 256ms 7.1s
recipe (name) 21ms 23ms 24ms 43ms 11ms 7.4s
recipe (description) 20ms 21ms 23ms 34ms 0ms 4.8s
recipe (instructions) 5ms 7ms 8ms 17ms 0ms 3.1s
synthetic (title) 52ms 54ms 57ms 284ms 836ms 12.9s
synthetic (string inside object) 49ms 52ms 62ms 340ms 779ms 8.3s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…d useActiveReleases hooks
Copy link
Contributor

@RitaDias RitaDias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we love to see it, we love to see it
wonder if it's worth creating a mock file for the useActiveReleases for other people to use in their tests but it's not a blocker

@jordanl17 jordanl17 merged commit 24ee87c into next Mar 14, 2025
61 checks passed
@jordanl17 jordanl17 deleted the test/release-store-tests branch March 14, 2025 11:11
@jordanl17
Copy link
Member Author

we love to see it, we love to see it wonder if it's worth creating a mock file for the useActiveReleases for other people to use in their tests but it's not a blocker

Yeh that's a good idea! I'll add that, thanks for the consideration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants