Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: published perspective shows correct tooltip for create buttons #8923

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

jordanl17
Copy link
Member

@jordanl17 jordanl17 commented Mar 13, 2025

Description

Before After
Screenshot 2025-03-13 at 13 53 39 Screenshot 2025-03-13 at 13 53 15

What to review

Testing

N/A

Notes for release

N/A

Copy link

vercel bot commented Mar 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2025 4:02pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2025 4:02pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2025 4:02pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Mar 13, 2025 4:02pm
test-next-studio ⬜️ Ignored (Inspect) Mar 13, 2025 4:02pm

Copy link
Contributor

github-actions bot commented Mar 13, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 42.01% 54448 / 129598
🔵 Statements 42.01% 54448 / 129598
🔵 Functions 46.89% 2729 / 5820
🔵 Branches 79.42% 10211 / 12856
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/sanity/src/structure/components/paneHeaderActions/PaneHeaderCreateButton.tsx 10.88% 100% 0% 10.88% 33-52, 59-217
Generated in workflow #32264 for commit 0e66c29 by the Vitest Coverage Report Action

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Mar 13, 2025

⚡️ Editor Performance Report

Updated Thu, 13 Mar 2025 16:03:51 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 18.3 efps (55ms) 23.3 efps (43ms) -12ms (-21.1%)
article (body) 61.5 efps (16ms) 67.8 efps (15ms) -2ms (-9.2%)
article (string inside object) 20.4 efps (49ms) 25.6 efps (39ms) -10ms (-20.4%)
article (string inside array) 18.2 efps (55ms) 22.2 efps (45ms) -10ms (-18.2%)
recipe (name) 43.5 efps (23ms) 45.5 efps (22ms) -1ms (-4.3%)
recipe (description) 47.6 efps (21ms) 50.0 efps (20ms) -1ms (-4.8%)
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (5ms) +0ms (-/-%)
synthetic (title) 17.9 efps (56ms) 19.2 efps (52ms) -4ms (-7.1%)
synthetic (string inside object) 18.9 efps (53ms) 19.4 efps (52ms) -2ms (-2.8%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 55ms 62ms 77ms 399ms 1830ms 13.0s
article (body) 16ms 19ms 26ms 201ms 327ms 5.8s
article (string inside object) 49ms 51ms 57ms 171ms 917ms 8.5s
article (string inside array) 55ms 60ms 64ms 248ms 1308ms 9.0s
recipe (name) 23ms 26ms 29ms 58ms 1ms 7.5s
recipe (description) 21ms 23ms 31ms 44ms 0ms 5.0s
recipe (instructions) 5ms 7ms 8ms 10ms 0ms 3.1s
synthetic (title) 56ms 61ms 70ms 275ms 1126ms 13.6s
synthetic (string inside object) 53ms 55ms 63ms 278ms 846ms 8.0s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 43ms 49ms 83ms 350ms 650ms 11.3s
article (body) 15ms 17ms 22ms 259ms 408ms 5.7s
article (string inside object) 39ms 41ms 45ms 158ms 157ms 7.1s
article (string inside array) 45ms 49ms 56ms 143ms 324ms 7.8s
recipe (name) 22ms 24ms 29ms 49ms 0ms 7.3s
recipe (description) 20ms 21ms 22ms 34ms 0ms 4.8s
recipe (instructions) 5ms 8ms 9ms 14ms 0ms 3.2s
synthetic (title) 52ms 57ms 72ms 275ms 878ms 13.2s
synthetic (string inside object) 52ms 56ms 60ms 411ms 1110ms 8.7s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Copy link
Contributor

@juice49 juice49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement!

@jordanl17 jordanl17 merged commit c27c518 into next Mar 14, 2025
60 checks passed
@jordanl17 jordanl17 deleted the fix/sapp-2495 branch March 14, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants