Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sanity): refine phrasing of scheduled-for-publishing-on string #8922

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

juice49
Copy link
Contributor

@juice49 juice49 commented Mar 13, 2025

Description

Tiny copy refinement.

What to review

The copy change.

@juice49 juice49 requested a review from a team as a code owner March 13, 2025 15:20
@juice49 juice49 requested review from binoy14 and removed request for a team March 13, 2025 15:20
Copy link

vercel bot commented Mar 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2025 3:27pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2025 3:27pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2025 3:27pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Mar 13, 2025 3:27pm
test-next-studio ⬜️ Ignored (Inspect) Mar 13, 2025 3:27pm

Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 42.01% 54448 / 129591
🔵 Statements 42.01% 54448 / 129591
🔵 Functions 46.89% 2729 / 5820
🔵 Branches 79.42% 10210 / 12855
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/sanity/src/core/i18n/bundles/studio.ts 100% 100% 100% 100%
Generated in workflow #32262 for commit f5ddd58 by the Vitest Coverage Report Action

Copy link
Contributor

⚡️ Editor Performance Report

Updated Thu, 13 Mar 2025 15:33:11 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 24.4 efps (41ms) 20.6 efps (49ms) +8ms (+18.3%)
article (body) 72.2 efps (14ms) 84.4 efps (12ms) -2ms (-/-%)
article (string inside object) 26.3 efps (38ms) 20.0 efps (50ms) +12ms (+31.6%) 🔴
article (string inside array) 24.4 efps (41ms) 17.9 efps (56ms) +15ms (+36.6%) 🔴
recipe (name) 28.6 efps (35ms) 30.3 efps (33ms) -2ms (-5.7%)
recipe (description) 32.3 efps (31ms) 32.8 efps (31ms) -1ms (-1.6%)
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (5ms) +0ms (-/-%)
synthetic (title) 18.2 efps (55ms) 19.2 efps (52ms) -3ms (-5.5%)
synthetic (string inside object) 18.9 efps (53ms) 20.4 efps (49ms) -4ms (-7.5%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 41ms 44ms 52ms 77ms 215ms 11.4s
article (body) 14ms 17ms 23ms 222ms 326ms 5.4s
article (string inside object) 38ms 40ms 43ms 127ms 128ms 6.7s
article (string inside array) 41ms 44ms 49ms 220ms 296ms 7.0s
recipe (name) 35ms 36ms 40ms 80ms 126ms 9.7s
recipe (description) 31ms 35ms 43ms 52ms 57ms 6.5s
recipe (instructions) 5ms 7ms 8ms 13ms 0ms 3.2s
synthetic (title) 55ms 58ms 65ms 358ms 1489ms 13.2s
synthetic (string inside object) 53ms 56ms 66ms 331ms 1177ms 8.5s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 49ms 53ms 75ms 342ms 1224ms 12.1s
article (body) 12ms 14ms 15ms 57ms 184ms 5.0s
article (string inside object) 50ms 51ms 55ms 286ms 922ms 8.3s
article (string inside array) 56ms 58ms 61ms 291ms 1382ms 9.2s
recipe (name) 33ms 35ms 39ms 51ms 61ms 8.8s
recipe (description) 31ms 32ms 33ms 71ms 8ms 6.3s
recipe (instructions) 5ms 7ms 8ms 30ms 0ms 3.2s
synthetic (title) 52ms 55ms 62ms 363ms 1004ms 13.5s
synthetic (string inside object) 49ms 52ms 54ms 207ms 551ms 7.6s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@juice49 juice49 enabled auto-merge (squash) March 13, 2025 20:32
Copy link
Contributor

No changes to documentation

@juice49 juice49 merged commit bbd4cc3 into next Mar 13, 2025
61 checks passed
@juice49 juice49 deleted the feat/sapp-2431/scheduled-to-be-published-copy branch March 13, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants