-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(e2e): set up display documents e2e 2 #8908
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
No changes to documentation |
Coverage Report
File CoverageNo changed files found. |
⚡️ Editor Performance ReportUpdated Fri, 14 Mar 2025 10:48:31 GMT
Detailed information🏠 Reference resultThe performance result of
🧪 Experiment resultThe performance result of this branch
📚 Glossary
|
dd4db3e
to
4ab317e
Compare
4ab317e
to
7c07c5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great addition, thank you for @RitaDias! Left some comments, mostly minor stuff, please take a look. Would be great if we could avoid the duplication in the test.skip()
condition.
test/e2e/tests/releases/displayDocument/DisplayedDocument.spec.ts
Outdated
Show resolved
Hide resolved
test/e2e/tests/releases/displayDocument/DisplayedDocument.spec.ts
Outdated
Show resolved
Hide resolved
@bjoerge moved the skip condition to its own method, call it wherever it's needed :) |
test/e2e/tests/releases/displayDocument/DisplayedDocument.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 🎉 🎉
Description
Note
The code is the same as the previous PR I had open, I just moved the tests to a single file
Added e2e tests to test document displayed from #8759
Same code as #8828 with minor changes
In order to reduce flake:
What to review
Do the tests make sense?
Notes for release
N/A