Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(studio): refine releases overview toolbar layout #8881

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

juice49
Copy link
Contributor

@juice49 juice49 commented Mar 11, 2025

Description

This branch makes some small changes to improve the releases overview toolbar layout and make the buttons more consistent.

This is best illustrated with the flex layout highlighted.

Before

Screenshot 2025-03-11 at 09 36 11

After

Screenshot 2025-03-11 at 09 35 35

What to review

The updated layout.

Testing

Tested the layout manually in web browser.

@juice49 juice49 requested a review from a team as a code owner March 11, 2025 09:40
@juice49 juice49 requested review from RitaDias and removed request for a team March 11, 2025 09:40
Copy link

vercel bot commented Mar 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2025 9:45am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2025 9:45am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2025 9:45am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Mar 11, 2025 9:45am
test-next-studio ⬜️ Ignored (Inspect) Mar 11, 2025 9:45am

Copy link
Contributor

@RitaDias RitaDias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

No changes to documentation

Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 42.01% 54401 / 129477
🔵 Statements 42.01% 54401 / 129477
🔵 Functions 46.88% 2728 / 5819
🔵 Branches 79.32% 10173 / 12825
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/sanity/src/core/releases/tool/overview/ReleasesOverview.tsx 94.72% 86.9% 75% 94.72% 97, 139-140, 158, 174, 243-247, 281-283, 290-294
Generated in workflow #31955 for commit 390c9d2 by the Vitest Coverage Report Action

Copy link
Contributor

github-actions bot commented Mar 11, 2025

⚡️ Editor Performance Report

Updated Tue, 11 Mar 2025 15:08:41 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 25.6 efps (39ms) 26.3 efps (38ms) -1ms (-2.6%)
article (body) 88.1 efps (11ms) 78.1 efps (13ms) +1ms (-/-%)
article (string inside object) 28.6 efps (35ms) 27.0 efps (37ms) +2ms (+5.7%)
article (string inside array) 24.4 efps (41ms) 23.8 efps (42ms) +1ms (+2.4%)
recipe (name) 43.5 efps (23ms) 47.6 efps (21ms) -2ms (-8.7%)
recipe (description) 50.0 efps (20ms) 50.0 efps (20ms) +0ms (-/-%)
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (6ms) +0ms (-/-%)
synthetic (title) 19.2 efps (52ms) 19.4 efps (52ms) -1ms (-1.0%)
synthetic (string inside object) 19.0 efps (53ms) 18.9 efps (53ms) +1ms (+1.0%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 39ms 42ms 46ms 149ms 257ms 10.9s
article (body) 11ms 13ms 15ms 44ms 37ms 4.5s
article (string inside object) 35ms 36ms 42ms 152ms 153ms 6.4s
article (string inside array) 41ms 44ms 47ms 293ms 395ms 7.2s
recipe (name) 23ms 25ms 26ms 34ms 0ms 7.8s
recipe (description) 20ms 21ms 23ms 32ms 0ms 4.8s
recipe (instructions) 6ms 7ms 8ms 17ms 0ms 3.2s
synthetic (title) 52ms 59ms 73ms 360ms 1080ms 13.4s
synthetic (string inside object) 53ms 56ms 61ms 214ms 1022ms 8.1s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 38ms 40ms 43ms 236ms 61ms 11.2s
article (body) 13ms 14ms 20ms 31ms 162ms 4.9s
article (string inside object) 37ms 39ms 48ms 146ms 123ms 6.7s
article (string inside array) 42ms 45ms 48ms 138ms 173ms 7.0s
recipe (name) 21ms 23ms 25ms 43ms 0ms 7.4s
recipe (description) 20ms 21ms 25ms 41ms 0ms 4.8s
recipe (instructions) 6ms 8ms 9ms 9ms 0ms 3.1s
synthetic (title) 52ms 55ms 57ms 353ms 946ms 12.6s
synthetic (string inside object) 53ms 55ms 59ms 260ms 914ms 8.3s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Copy link
Contributor

github-actions bot commented Mar 11, 2025

Component Testing Report Updated Mar 11, 2025 3:31 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 5s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 36s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 49s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 25s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 5s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 32s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 43s 21 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 12s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 36s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

@juice49 juice49 merged commit 16919e6 into next Mar 11, 2025
68 checks passed
@juice49 juice49 deleted the feat/sapp-2091/refine-releases-overview-toolbar branch March 11, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants