-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): arrays of references support disableActions #8877
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
No changes to documentation |
Coverage Report
File Coverage
|
Component Testing Report Updated Mar 11, 2025 12:48 PM (UTC) ❌ Failed Tests (1) -- expand for details
|
⚡️ Editor Performance ReportUpdated Tue, 11 Mar 2025 14:32:28 GMT
Detailed information🏠 Reference resultThe performance result of
🧪 Experiment resultThe performance result of this branch
📚 Glossary
|
7956c6e
to
8e39532
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, good catch!
@@ -63,6 +63,7 @@ const playwrightConfig = createPlaywrightConfig({ | |||
reporter: excludeGithub([['list'], ['blob']]), | |||
use: { | |||
...config.use, | |||
video: 'retain-on-failure', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems unrelated, was it intentional?
Description
The same logic that is used across other arrays of items eg
/packages/sanity/src/core/form/inputs/arrays/ArrayOfPrimitivesInput/ItemRow.tsx
, has been added to themenu
rendered inReferenceItem
, so that support foroptions.disableActions
is brought to arrays of references.There is a separate minor refactor that will be raised shortly which will consolidate all array item menus from a single hook that can be reused both here, in
ItemRow
and elsewhere that currently duplicates logic.Note, the
arrayCapabilities
schema type has been updated and amended to expand its test usageWhat to review
Testing
Manually verified
Notes for release
options.disableActions
is supported on items in an array of references. More details ondisableActions
here