feat(sanity): refine release creation dialogue #8875

juice49 · 2025-03-10T17:05:55Z

Description

This branch implements release creation dialogue and release form refinements.

Note that this branch does not move the timezone control into the date picker, as that change would be quite a lot wider in scope.

Screen.Recording.2025-03-10.at.21.22.02.mov

What to review

The release creation UI (dialogue and form).

Testing

Existing tests pass.

Notes for release

Refines release creation UI, making it easier to use across a wider range of viewport sizes.

vercel · 2025-03-10T17:06:01Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
page-building-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 11, 2025 4:05pm
performance-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 11, 2025 4:05pm
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 11, 2025 4:05pm

2 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)	Visit Preview		Mar 11, 2025 4:05pm
test-next-studio	⬜️ Ignored (Inspect)			Mar 11, 2025 4:05pm

github-actions · 2025-03-10T17:10:52Z

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	42.02%	54441 / 129554
🔵	Statements	42.02%	54441 / 129554
🔵	Functions	46.89%	2729 / 5820
🔵	Branches	79.44%	10218 / 12862

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
packages/sanity/src/core/releases/components/ScheduleDatePicker.tsx	23.07%	100%	0%	23.07%	26-74
packages/sanity/src/core/releases/components/dialog/CreateReleaseDialog.tsx	83.14%	100%	100%	83.14%	50-64
packages/sanity/src/core/releases/components/dialog/ReleaseForm.tsx	80.28%	94.11%	66.66%	80.28%	62-63, 70-93, 117-120, 187-198
packages/sanity/src/core/releases/components/dialog/TitleDescriptionForm.tsx	98.88%	100%	100%	98.88%	147
packages/sanity/src/core/releases/store/types.ts	70%	100%	50%	70%	24-27

Generated in workflow #32043 for commit c6e5b24 by the Vitest Coverage Report Action

github-actions · 2025-03-10T17:10:53Z

No changes to documentation

github-actions · 2025-03-10T17:16:22Z

Component Testing Report Updated Mar 10, 2025 9:14 PM (UTC)

❌ Failed Tests (3) -- expand for details

File	Status	Duration	Passed	Skipped	Failed
comments/CommentInput.spec.tsx	✅ Passed (Inspect)	1m 3s	15	0	0
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	13s	3	0	0
formBuilder/inputs/PortableText/Annotations.spec.tsx	❌ Failed (Inspect)	1m 17s	5	0	1
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx	✅ Passed (Inspect)	42s	11	7	0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx	✅ Passed (Inspect)	0s	0	12	0
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	24s	6	0	0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx	✅ Passed (Inspect)	14s	3	0	0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx	✅ Passed (Inspect)	25s	6	0	0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx	❌ Failed (Inspect)	1m 43s	14	0	1
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	1m 34s	21	0	0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	✅ Passed (Inspect)	1m 47s	21	0	0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx	✅ Passed (Inspect)	13s	3	9	0
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	26s	6	0	0
formBuilder/inputs/PortableText/Toolbar.spec.tsx	❌ Failed (Inspect)	2m 14s	20	0	1
formBuilder/tree-editing/TreeEditing.spec.tsx	✅ Passed (Inspect)	0s	0	3	0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx	✅ Passed (Inspect)	0s	0	3	0

github-actions · 2025-03-10T17:18:49Z

⚡️ Editor Performance Report

Updated Tue, 11 Mar 2025 16:19:55 GMT

Benchmark	reference ^{latency of sanity@latest}	experiment ^{latency of this branch}	Δ (%) ^{latency difference}
article (title)	19.2 efps (52ms)	19.2 efps (52ms)	+0ms (-/-%)	✅
article (body)	75.2 efps (13ms)	68.3 efps (15ms)	+1ms (-/-%)	✅
article (string inside object)	20.2 efps (50ms)	20.0 efps (50ms)	+1ms (+1.0%)	✅
article (string inside array)	18.7 efps (54ms)	18.0 efps (56ms)	+2ms (+3.7%)	✅
recipe (name)	43.5 efps (23ms)	29.4 efps (34ms)	+11ms (+47.8%)	🔴
recipe (description)	52.6 efps (19ms)	33.3 efps (30ms)	+11ms (+57.9%)	🔴
recipe (instructions)	99.9+ efps (6ms)	99.9+ efps (6ms)	+0ms (-/-%)	✅
synthetic (title)	19.6 efps (51ms)	16.7 efps (60ms)	+9ms (+17.6%)	✅
synthetic (string inside object)	19.6 efps (51ms)	16.9 efps (59ms)	+8ms (+15.7%)	✅

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	52ms	61ms	99ms	253ms	1667ms	13.4s
article (body)	13ms	15ms	17ms	27ms	55ms	5.0s
article (string inside object)	50ms	51ms	58ms	289ms	1004ms	8.5s
article (string inside array)	54ms	56ms	62ms	163ms	1096ms	8.5s
recipe (name)	23ms	24ms	26ms	46ms	0ms	7.6s
recipe (description)	19ms	21ms	22ms	28ms	0ms	4.7s
recipe (instructions)	6ms	8ms	9ms	10ms	0ms	3.3s
synthetic (title)	51ms	54ms	57ms	214ms	873ms	12.7s
synthetic (string inside object)	51ms	55ms	61ms	114ms	644ms	7.8s

🧪 Experiment result

The performance result of this branch

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	52ms	58ms	78ms	281ms	1293ms	11.9s
article (body)	15ms	16ms	18ms	90ms	141ms	5.0s
article (string inside object)	50ms	54ms	57ms	173ms	1090ms	8.8s
article (string inside array)	56ms	58ms	62ms	96ms	1000ms	8.5s
recipe (name)	34ms	37ms	42ms	66ms	104ms	9.0s
recipe (description)	30ms	32ms	37ms	54ms	61ms	6.3s
recipe (instructions)	6ms	7ms	8ms	9ms	0ms	3.2s
synthetic (title)	60ms	62ms	66ms	233ms	1851ms	19.1s
synthetic (string inside object)	59ms	61ms	63ms	118ms	1613ms	9.3s

📚 Glossary

column definitions

benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".

latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.

p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.

p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.

p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.

blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.

test duration — how long the test run took to complete.

jordanl17 · 2025-03-11T12:09:13Z

NIT: the positioning of the dropdown isn't aligned when creating a new version from the 'copy to' flow:

bjoerge

Very nice

juice49 · 2025-03-11T16:04:39Z

@jordanl17 thanks for pointing that out! I've resolved this by explicitly setting a boundary element.

vercel bot deployed to Preview – page-building-studio March 10, 2025 17:12 View deployment

vercel bot deployed to Preview – performance-studio March 10, 2025 17:12 View deployment

vercel bot deployed to Preview – test-studio March 10, 2025 17:12 View deployment

juice49 force-pushed the feat/sapp-2409/refine-release-creation-dialogue branch from 5f5c733 to b3bdea7 Compare March 10, 2025 21:01

juice49 added 2 commits March 10, 2025 21:02

feat(sanity): add isReleaseType type guard (#8875)

Verified

This commit was signed with the committer’s verified signature.

mnecas Martin Nečas

GPG key ID: 96209CD2C69E7184

Verified
Learn about vigilant mode

Loading
Loading status checks…

9653704

feat(sanity): refine TitleDescriptionForm block spacing (#8875)

3040920

juice49 added a commit that referenced this pull request Mar 10, 2025

feat(sanity): refine release creation dialogue (#8875)

39b1e87

juice49 force-pushed the feat/sapp-2409/refine-release-creation-dialogue branch from b3bdea7 to 39b1e87 Compare March 10, 2025 21:03

vercel bot deployed to Preview – performance-studio March 10, 2025 21:08 View deployment

vercel bot deployed to Preview – page-building-studio March 10, 2025 21:08 View deployment

vercel bot deployed to Preview – test-studio March 10, 2025 21:09 View deployment

juice49 marked this pull request as ready for review March 10, 2025 21:38

juice49 requested a review from a team as a code owner March 10, 2025 21:38

juice49 requested review from bjoerge and removed request for a team March 10, 2025 21:39

bjoerge previously approved these changes Mar 11, 2025

View reviewed changes

feat(sanity): refine release creation dialogue (#8875)

c6e5b24

juice49 dismissed bjoerge’s stale review via c6e5b24 March 11, 2025 15:58

juice49 force-pushed the feat/sapp-2409/refine-release-creation-dialogue branch from 39b1e87 to c6e5b24 Compare March 11, 2025 15:58

juice49 requested a review from jordanl17 March 11, 2025 16:04

vercel bot deployed to Preview – performance-studio March 11, 2025 16:04 View deployment

vercel bot deployed to Preview – page-building-studio March 11, 2025 16:05 View deployment

vercel bot deployed to Preview – test-studio March 11, 2025 16:05 View deployment

juice49 enabled auto-merge (rebase) March 11, 2025 16:12

jordanl17 approved these changes Mar 12, 2025

View reviewed changes

juice49 merged commit a4f4af3 into next Mar 12, 2025
66 checks passed

juice49 deleted the feat/sapp-2409/refine-release-creation-dialogue branch March 12, 2025 10:41

juice49 added a commit that referenced this pull request Mar 12, 2025

feat(sanity): add isReleaseType type guard (#8875)

db83d84

juice49 added a commit that referenced this pull request Mar 12, 2025

feat(sanity): refine TitleDescriptionForm block spacing (#8875)

0ec5daf

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(sanity): refine release creation dialogue #8875

feat(sanity): refine release creation dialogue #8875

juice49 commented Mar 10, 2025 •

edited

Loading

vercel bot commented Mar 10, 2025 •

edited

Loading

github-actions bot commented Mar 10, 2025 •

edited

Loading

github-actions bot commented Mar 10, 2025

github-actions bot commented Mar 10, 2025 •

edited

Loading

github-actions bot commented Mar 10, 2025 •

edited

Loading

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

jordanl17 commented Mar 11, 2025

bjoerge left a comment

juice49 commented Mar 11, 2025

feat(sanity): refine release creation dialogue #8875

feat(sanity): refine release creation dialogue #8875

Conversation

juice49 commented Mar 10, 2025 • edited Loading

Description

What to review

Testing

Notes for release

vercel bot commented Mar 10, 2025 • edited Loading

github-actions bot commented Mar 10, 2025 • edited Loading

Coverage Report

github-actions bot commented Mar 10, 2025

github-actions bot commented Mar 10, 2025 • edited Loading

github-actions bot commented Mar 10, 2025 • edited Loading

⚡️ Editor Performance Report

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

jordanl17 commented Mar 11, 2025

bjoerge left a comment

Choose a reason for hiding this comment

juice49 commented Mar 11, 2025

juice49 commented Mar 10, 2025 •

edited

Loading

vercel bot commented Mar 10, 2025 •

edited

Loading

github-actions bot commented Mar 10, 2025 •

edited

Loading

github-actions bot commented Mar 10, 2025 •

edited

Loading

github-actions bot commented Mar 10, 2025 •

edited

Loading