Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add CI specific token label #7934

Merged
merged 5 commits into from
Dec 3, 2024
Merged

feat: add CI specific token label #7934

merged 5 commits into from
Dec 3, 2024
+11 −4

Conversation

RostiMelk
Copy link
Member

Description

Adding CI specific token label "ci-remote-template-test-token-please-add-email-filter" than can be easily filtered to avoid spam in your mailbox.

What to review

Do you get the correct token in your email?

Testing

N/A

Notes for release

N/A

@RostiMelk RostiMelk requested a review from a team as a code owner December 3, 2024 12:49
@RostiMelk RostiMelk requested review from ricokahler and removed request for a team December 3, 2024 12:49
@vercel Vercel
Copy link

vercel bot commented Dec 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 4:32pm
performance-studio ✅ Ready (Inspect) Visit Preview Dec 3, 2024 4:32pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 4:32pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 4:32pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2024 4:32pm

@RostiMelk
feat: slate data

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
6576ca9
@RostiMelk
feat: boolean
Loading
Loading status checks…
f05215c
bjoerge
bjoerge approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank u!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024 •
edited
Loading

Component Testing Report Updated Dec 3, 2024 7:26 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 10s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 13s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 40s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 54s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 2m 7s 2 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 8s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 2m 45s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 44s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 41s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 28s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 54s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024 •
edited
Loading

⚡️ Editor Performance Report

Updated Tue, 03 Dec 2024 16:29:57 GMT

Benchmark reference
latency of sanity@latest		 experiment
latency of this branch		 Δ (%)
latency difference
article (title) 19.8 efps (51ms) 21.3 efps (47ms) -4ms (-6.9%) ✅
article (body) 48.4 efps (21ms) 58.1 efps (17ms) -3ms (-16.7%) ✅
article (string inside object) 22.7 efps (44ms) 23.8 efps (42ms) -2ms (-4.5%) ✅
article (string inside array) 21.3 efps (47ms) 20.4 efps (49ms) +2ms (+4.3%) ✅
recipe (name) 41.7 efps (24ms) 43.5 efps (23ms) -1ms (-4.2%) ✅
recipe (description) 50.0 efps (20ms) 47.6 efps (21ms) +1ms (+5.0%) ✅
recipe (instructions) 99.9+ efps (9ms) 99.9+ efps (7ms) -2ms (-/-%) ✅
synthetic (title) 16.1 efps (62ms) 17.2 efps (58ms) -4ms (-6.5%) ✅
synthetic (string inside object) 17.5 efps (57ms) 17.5 efps (57ms) +0ms (-/-%) ✅

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 51ms 54ms 64ms 203ms 221ms 11.9s
article (body) 21ms 23ms 38ms 160ms 232ms 6.3s
article (string inside object) 44ms 46ms 51ms 101ms 196ms 7.4s
article (string inside array) 47ms 54ms 61ms 178ms 323ms 7.9s
recipe (name) 24ms 26ms 26ms 70ms 25ms 8.9s
recipe (description) 20ms 22ms 23ms 32ms 0ms 4.8s
recipe (instructions) 9ms 11ms 12ms 28ms 0ms 3.6s
synthetic (title) 62ms 65ms 75ms 375ms 1002ms 15.3s
synthetic (string inside object) 57ms 61ms 79ms 471ms 1110ms 9.1s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 47ms 51ms 56ms 189ms 206ms 11.7s
article (body) 17ms 19ms 21ms 207ms 253ms 5.7s
article (string inside object) 42ms 45ms 52ms 172ms 162ms 7.3s
article (string inside array) 49ms 55ms 57ms 179ms 195ms 7.9s
recipe (name) 23ms 25ms 35ms 45ms 0ms 8.4s
recipe (description) 21ms 22ms 24ms 165ms 0ms 5.2s
recipe (instructions) 7ms 9ms 10ms 35ms 0ms 3.4s
synthetic (title) 58ms 60ms 69ms 151ms 556ms 17.8s
synthetic (string inside object) 57ms 59ms 67ms 314ms 771ms 8.3s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@bjoerge bjoerge added this pull request to the merge queue Dec 3, 2024
Merged via the queue into next with commit 4b64fbb Dec 3, 2024
54 of 55 checks passed
@bjoerge bjoerge deleted the feat/cli/check-is-ci-for-token branch December 3, 2024 19:27
bjoerge added a commit that referenced this pull request Dec 3, 2024
@bjoerge
Merge branch 'next' into corel
Loading
Loading status checks…
862eaad 
* next:
  feat: add CI specific token label (#7934)
  fix(deps): update dependency @sanity/client to ^6.24.1 (#7938)
  fix(vision): add a warning about unsupported perspective when pasting (#7937)
  fix(deps): bump sentry/react to 8.33 (#7932)
  fix(deps): update dependency @sanity/client to ^6.24.0 (#7935)
  fix(deps): update dependency @portabletext/editor to ^1.12.3 (#7921)
  fix(deps): update dependency @sanity/icons to ^3.5.0 (#7929)
  chore(deps): dedupe pnpm-lock.yaml (#7933)
  feat(cli): add support for remote templates with `--template`  (#7867)
  test(e2e): add unpublish e2e test (#7927)
  feat(cli): remove v2 init messaging (#7887)
  fix: support react compiler for auto updating studios (#7897)
  fix(deps): Update dev-non-major (#7920)
  fix(deps): update dependency @sanity/presentation to v1.19.4 (#7930)
  chore(deps): update typescript-tooling (#7928)
  fix(deps): update dependency @sanity/client to ^6.23.0 (#7931)
  feat(cli): add test-template for testing `--template` flag (#7877)
bjoerge added a commit that referenced this pull request Dec 4, 2024
@bjoerge
Merge branch 'next' into corel
Loading
Loading status checks…
28e91ea 
* next: (22 commits)
  fix: add svg hotspot+crop warning to image tool dialog (#7917)
  fix(deps): Update dev-non-major (#7946)
  fix(deps): update dependency @sanity/insert-menu to v1.0.16 (#7942)
  chore(vision): revert accidental file rename (#7945)
  fix(deps): update dependency @portabletext/editor to ^1.13.0 (#7939)
  feat: add CI specific token label (#7934)
  fix(deps): update dependency @sanity/client to ^6.24.1 (#7938)
  fix(vision): add a warning about unsupported perspective when pasting (#7937)
  fix(deps): bump sentry/react to 8.33 (#7932)
  fix(deps): update dependency @sanity/client to ^6.24.0 (#7935)
  fix(deps): update dependency @portabletext/editor to ^1.12.3 (#7921)
  fix(deps): update dependency @sanity/icons to ^3.5.0 (#7929)
  chore(deps): dedupe pnpm-lock.yaml (#7933)
  feat(cli): add support for remote templates with `--template`  (#7867)
  test(e2e): add unpublish e2e test (#7927)
  feat(cli): remove v2 init messaging (#7887)
  fix: support react compiler for auto updating studios (#7897)
  fix(deps): Update dev-non-major (#7920)
  fix(deps): update dependency @sanity/presentation to v1.19.4 (#7930)
  chore(deps): update typescript-tooling (#7928)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoerge bjoerge

@ricokahler ricokahler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RostiMelk @bjoerge