fix(sanity): allow discovery of all document versions using groq2024 search (#8775)

Author: juice49

packages/sanity/src/core/search/groq2024/createGroq2024Search.ts

@@ -23,6 +23,9 @@ function getSearchTerms(
 }
 
 /**
+ * Note: When using the `raw` persepctive, `groq2024` may emit uncollated documents, manifesting as
+ * duplicate search results. Consumers must collate the results.
+ *
  * @internal
  */
 export const createGroq2024Search: SearchStrategyFactory<Groq2024SearchResults> = (

packages/sanity/src/core/search/groq2024/createSearchQuery.test.ts

@@ -44,7 +44,7 @@ describe('createSearchQuery', () => {
       expect(query).toMatchInlineSnapshot(
         `
         "// findability-mvi:5
-        *[_type in $__types && !(_id in path("versions.**"))] | score(boost(_type in ["basic-schema-test"] && title match text::query($__query), 10), [@, _id] match text::query($__query)) | order(_score desc) [_score > 0] [0...$__limit] {_score, _type, _id, _originalId}"
+        *[_type in $__types] | score(boost(_type in ["basic-schema-test"] && title match text::query($__query), 10), [@, _id] match text::query($__query)) | order(_score desc) [_score > 0] [0...$__limit] {_score, _type, _id, _originalId}"
       `,
       )
 
@@ -58,19 +58,20 @@ describe('createSearchQuery', () => {
 
   describe('searchOptions', () => {
     it('should include drafts by default', () => {
-      const {options} = createSearchQuery(
+      const {query, options} = createSearchQuery(
         {
           query: 'term0',
           types: [testType],
         },
         '',
       )
 
-      expect(options.perspective).toBe('previewDrafts')
+      expect(query).not.toMatch(`!(_id in path('drafts.**'))`)
+      expect(options.perspective).toBe('raw')
     })
 
     it('should exclude drafts when configured', () => {
-      const {options} = createSearchQuery(
+      const {query, options} = createSearchQuery(
         {
           query: 'term0',
           types: [testType],
@@ -79,50 +80,33 @@ describe('createSearchQuery', () => {
         {includeDrafts: false},
       )
 
-      expect(options.perspective).toBe('published')
+      expect(query).toMatch(`!(_id in path('drafts.**'))`)
+      expect(options.perspective).toBe('raw')
     })
 
-    it('should give `perspective` precedence over `includeDrafts`', () => {
-      const {options: optionsIncludeDrafts} = createSearchQuery(
-        {
-          query: 'term0',
-          types: [testType],
-        },
-        '',
-        {
-          includeDrafts: true,
-          perspective: 'published',
-        },
-      )
-
-      expect(optionsIncludeDrafts.perspective).toBe('published')
-
-      const {options: optionsExcludeDrafts} = createSearchQuery(
+    it('should use `raw` perspective when no perspective provided', () => {
+      const {options} = createSearchQuery(
         {
           query: 'term0',
           types: [testType],
         },
         '',
-        {
-          includeDrafts: false,
-          perspective: 'drafts',
-        },
       )
 
-      expect(optionsExcludeDrafts.perspective).toBe('drafts')
+      expect(options.perspective).toBe('raw')
     })
 
-    it('should add no perspective parameter when `raw` perspective provided', () => {
+    it('should use `raw` perspective when empty perspective array provided', () => {
       const {options} = createSearchQuery(
         {
           query: 'term0',
           types: [testType],
         },
         '',
-        {perspective: 'raw'},
+        {perspective: []},
       )
 
-      expect(options.perspective).toBeUndefined()
+      expect(options.perspective).toBe('raw')
     })
 
     it('should use provided limit (plus one to determine existence of next page)', () => {
@@ -150,9 +134,7 @@ describe('createSearchQuery', () => {
         {filter: 'randomCondition == $customParam', params: {customParam: 'custom'}},
       )
 
-      expect(query).toContain(
-        '*[_type in $__types && (randomCondition == $customParam) && !(_id in path("versions.**"))]',
-      )
+      expect(query).toContain('*[_type in $__types && (randomCondition == $customParam)]')
       expect(params.customParam).toEqual('custom')
     })
 
@@ -188,7 +170,7 @@ describe('createSearchQuery', () => {
 
       expect(query).toMatchInlineSnapshot(`
         "// findability-mvi:5
-        *[_type in $__types && [@, _id] match text::query($__query) && !(_id in path("versions.**"))] | order(exampleField desc) [0...$__limit] {exampleField, _type, _id, _originalId}"
+        *[_type in $__types && [@, _id] match text::query($__query)] | order(exampleField desc) [0...$__limit] {exampleField, _type, _id, _originalId}"
       `)
 
       expect(query).toContain('| order(exampleField desc)')
@@ -222,7 +204,7 @@ describe('createSearchQuery', () => {
 
       expect(query).toMatchInlineSnapshot(`
         "// findability-mvi:5
-        *[_type in $__types && [@, _id] match text::query($__query) && !(_id in path("versions.**"))] | order(exampleField desc,anotherExampleField asc,lower(mapWithField) asc) [0...$__limit] {exampleField, anotherExampleField, mapWithField, _type, _id, _originalId}"
+        *[_type in $__types && [@, _id] match text::query($__query)] | order(exampleField desc,anotherExampleField asc,lower(mapWithField) asc) [0...$__limit] {exampleField, anotherExampleField, mapWithField, _type, _id, _originalId}"
       `)
 
       expect(query).toContain(
@@ -241,7 +223,7 @@ describe('createSearchQuery', () => {
 
       expect(query).toMatchInlineSnapshot(`
         "// findability-mvi:5
-        *[_type in $__types && !(_id in path("versions.**"))] | score(boost(_type in ["basic-schema-test"] && title match text::query($__query), 10), [@, _id] match text::query($__query)) | order(_score desc) [_score > 0] [0...$__limit] {_score, _type, _id, _originalId}"
+        *[_type in $__types] | score(boost(_type in ["basic-schema-test"] && title match text::query($__query), 10), [@, _id] match text::query($__query)) | order(_score desc) [_score > 0] [0...$__limit] {_score, _type, _id, _originalId}"
       `)
 
       expect(query).toContain('| order(_score desc)')
@@ -319,7 +301,7 @@ describe('createSearchQuery', () => {
 
       expect(query).toMatchInlineSnapshot(`
         "// findability-mvi:5
-        *[_type in $__types && !(_id in path("versions.**"))] | score(boost(_type in ["numbers-in-path"] && cover[].cards[].title match text::query($__query), 5), [@, _id] match text::query($__query)) | order(_score desc) [_score > 0] [0...$__limit] {_score, _type, _id, _originalId}"
+        *[_type in $__types] | score(boost(_type in ["numbers-in-path"] && cover[].cards[].title match text::query($__query), 5), [@, _id] match text::query($__query)) | order(_score desc) [_score > 0] [0...$__limit] {_score, _type, _id, _originalId}"
       `)
 
       expect(query).toContain('cover[].cards[].title match text::query($__query), 5)')

packages/sanity/src/core/search/groq2024/createSearchQuery.ts

@@ -1,3 +1,4 @@
+import {type ClientPerspective} from '@sanity/client'
 import {DEFAULT_MAX_FIELD_DEPTH} from '@sanity/schema/_internal'
 import {type CrossDatasetType, type SchemaType} from '@sanity/types'
 import {groupBy} from 'lodash'
@@ -68,8 +69,6 @@ export function createSearchQuery(
     )
     .filter(({paths}) => paths.length !== 0)
 
-  const isRaw = isPerspectiveRaw(perspective)
-
   // Note: Computing this is unnecessary when `!isScored`.
   const flattenedSpecs = specs
     .map(({typeName, paths}) => paths.map((path) => ({...path, typeName})))
@@ -93,13 +92,26 @@ export function createSearchQuery(
   const sortOrder = options?.sort ?? [{field: '_score', direction: 'desc'}]
   const isScored = sortOrder.some(({field}) => field === '_score')
 
+  let activePerspective: ClientPerspective | undefined = perspective
+
+  // No perspective, or empty perspective array, provided.
+  if (
+    typeof perspective === 'undefined' ||
+    (Array.isArray(perspective) && perspective.length === 0)
+  ) {
+    activePerspective = 'raw'
+  }
+
+  const isRaw = isPerspectiveRaw(activePerspective)
+
   const filters: string[] = [
     '_type in $__types',
     // If the search request doesn't use scoring, directly filter documents.
     isScored ? [] : baseMatch,
     options.filter ? `(${options.filter})` : [],
     searchTerms.filter ? `(${searchTerms.filter})` : [],
     isRaw ? [] : '!(_id in path("versions.**"))',
+    includeDrafts === false ? `!(_id in path('drafts.**'))` : [],
     options.cursor ?? [],
   ].flat()
 
@@ -130,22 +142,6 @@ export function createSearchQuery(
     .map((s) => `// ${s}`)
     .join('\n')
 
-  let activePerspective: string | string[] | undefined
-
-  switch (true) {
-    // Raw perspective provided.
-    case isRaw:
-      activePerspective = undefined
-      break
-    // Any other perspective provided.
-    case typeof perspective !== 'undefined':
-      activePerspective = perspective
-      break
-    // No perspective provided.
-    default:
-      activePerspective = includeDrafts ? 'previewDrafts' : 'published'
-  }
-
   return {
     query: [pragma, query].join('\n'),
     options: {

packages/sanity/src/core/studio/components/navbar/search/contexts/search/reducer.ts

@@ -1,12 +1,7 @@
-import {
-  type CurrentUser,
-  type SanityDocumentLike,
-  type SchemaType,
-  type SearchStrategy,
-} from '@sanity/types'
+import {type CurrentUser, type SchemaType, type SearchStrategy} from '@sanity/types'
 
 import {type SearchHit, type SearchTerms} from '../../../../../../search'
-import {collate} from '../../../../../../util'
+import {removeDupes} from '../../../../../../util/draftUtils'
 import {type RecentSearch} from '../../datastores/recentSearches'
 import {type SearchFieldDefinitionDictionary} from '../../definitions/fields'
 import {type SearchFilterDefinitionDictionary} from '../../definitions/filters'
@@ -231,9 +226,11 @@ export function searchReducer(state: SearchReducerState, action: SearchAction):
           ...state.result,
           error: null,
           hasLocal: true,
-          hits: collateHits(
-            state.result.hasLocal ? [...state.result.hits, ...action.hits] : action.hits,
-          ),
+          hits: state.result.hasLocal
+            ? removeDupes([...state.result.hits, ...action.hits].map(({hit}) => hit)).map(
+                (hit) => ({hit}),
+              )
+            : action.hits,
           loaded: true,
           loading: false,
         },
@@ -597,8 +594,3 @@ function stripRecent(terms: RecentSearch | SearchTerms) {
   }
   return terms
 }
-
-function collateHits(hits: SearchHit[]) {
-  const collated = collate(hits.map((h) => h.hit))
-  return collated.map((doc) => ({hit: (doc.draft || doc.published)! as SanityDocumentLike}))
-}