fix: prevent over-fetching in free trial provider (#8783)

Author: stipsan

packages/sanity/src/core/studio/components/navbar/free-trial/FreeTrialProvider.tsx

@@ -42,24 +42,21 @@ export const FreeTrialProvider = ({children}: FreeTrialProviderProps) => {
     }
   }, [showDialog, data, showOnLoad, telemetry])
 
-  // This is casted to a string to make it stable across renders so it doesn't trigger multiple times the effect.
-  const searchParamsAsString = new URLSearchParams(router.state._searchParams).toString()
+  // See if we have any parameters from the current route
+  // to pass onto our query
+  const searchParams = new URLSearchParams(router.state._searchParams)
+  // Allows us to override the current state of the trial to
+  // get back certain modals based on the current experience
+  // can be 'growth-trial', 'growth-trial-ending', or 'post-growth-trial'
+  const trialState = searchParams.get('trialState')
+  // Allows us to set whether we've seen the modals before
+  // or whether this is our first time seeing them (i.e. show a popup)
+  const seenBefore = searchParams.get('seenBefore')
 
   useEffect(() => {
-    // See if we have any parameters from the current route
-    // to pass onto our query
-    const searchParams = new URLSearchParams(searchParamsAsString)
-
     const queryParams = new URLSearchParams()
     queryParams.append('studioVersion', SANITY_VERSION)
-    // Allows us to override the current state of the trial to
-    // get back certain modals based on the current experience
-    // can be 'growth-trial', 'growth-trial-ending', or 'post-growth-trial'
-    const trialState = searchParams.get('trialState')
     if (trialState) queryParams.append('trialState', trialState)
-    // Allows us to set whether we've seen the modals before
-    // or whether this is our first time seeing them (i.e. show a popup)
-    const seenBefore = searchParams.get('seenBefore')
     if (seenBefore) queryParams.append('seenBefore', seenBefore)
     // If we have trialState, query the override endpoint so that we
     // get back trial modals for that state
@@ -84,7 +81,7 @@ export const FreeTrialProvider = ({children}: FreeTrialProviderProps) => {
     return () => {
       request.unsubscribe()
     }
-  }, [client, searchParamsAsString])
+  }, [client, seenBefore, trialState])
 
   const toggleShowContent = useCallback(
     (closeAndReOpen = false) => {

packages/sanity/src/core/tasks/context/navigation/TasksNavigationProvider.tsx

@@ -135,26 +135,22 @@ export const TasksNavigationProvider = ({children}: {children: ReactNode}) => {
       })
   }, [state.selectedTask, state.viewMode, telemetry, toast])
 
-  // This is casted to a string to make it stable across renders so it doesn't trigger multiple times the effect.
-  const searchParamsAsString = new URLSearchParams(router.state._searchParams).toString()
+  const searchParams = new URLSearchParams(router.state._searchParams)
+  const sidebar = searchParams.get('sidebar')
+  const viewMode = searchParams.get('viewMode')
+  const selectedTask = searchParams.get('selectedTask')
+
   useEffect(() => {
     // listen to the URL to open the tasks view if the sidebar is set to task.
-    if (searchParamsAsString) {
-      const searchParams = new URLSearchParams(searchParamsAsString)
-
-      const sidebar = searchParams.get('sidebar')
-      if (sidebar !== 'tasks') {
-        return
-      }
-      dispatch({type: 'TOGGLE_TASKS_VIEW', payload: true})
-      const viewMode = searchParams.get('viewMode')
-      const selectedTask = searchParams.get('selectedTask')
-      if (viewMode === 'edit' && selectedTask) {
-        dispatch({type: 'EDIT_TASK', payload: {id: selectedTask}})
-        telemetry.log(TaskLinkOpened)
-      }
+    if (sidebar !== 'tasks') {
+      return
+    }
+    dispatch({type: 'TOGGLE_TASKS_VIEW', payload: true})
+    if (viewMode === 'edit' && selectedTask) {
+      dispatch({type: 'EDIT_TASK', payload: {id: selectedTask}})
+      telemetry.log(TaskLinkOpened)
     }
-  }, [searchParamsAsString, telemetry])
+  }, [selectedTask, sidebar, telemetry, viewMode])
 
   const value = useMemo(
     () => ({