fix(studio): handle document-level copy/paste reference mismatches (#8895)

Author: cngonzalez

packages/sanity/src/core/studio/copyPaste/__test__/transferValue.test.ts

@@ -526,6 +526,54 @@ describe('transferValue', () => {
       ])
       expect(transferValueResult?.targetValue).toEqual(undefined)
     })
+
+    test('will properly preserve _weak and _strengthenOnPublish when copying a whole document with references', async () => {
+      const sourceValue = {
+        _type: 'referencesDocument',
+        _id: 'doc1',
+        reference: {
+          _type: 'reference',
+          _ref: 'yyy',
+          _weak: true,
+          _strengthenOnPublish: {
+            type: 'editor',
+          },
+        },
+      }
+      const targetRootValue = {
+        _type: 'referencesDocument',
+        _id: 'doc2',
+      }
+
+      const transferValueResult = await transferValue({
+        sourceRootSchemaType: schema.get('referencesDocument')!,
+        sourcePath: [],
+        sourceValue,
+        targetDocumentSchemaType: schema.get('referencesDocument')!,
+        targetRootSchemaType: schema.get('referencesDocument')!,
+        targetPath: [],
+        targetRootValue,
+        targetRootPath: [],
+        currentUser,
+        options: {
+          validateReferences: true,
+          client: createMockClient([{_type: 'editor', _id: 'yyy', name: 'John Doe'}]),
+        },
+      })
+
+      expect(transferValueResult?.errors).toEqual([])
+      expect(transferValueResult?.targetValue).toMatchObject({
+        _type: 'referencesDocument',
+        reference: {
+          _type: 'reference',
+          _ref: 'yyy',
+          _weak: true,
+          _strengthenOnPublish: {
+            type: 'editor',
+          },
+        },
+      })
+    })
   })
 
   describe('booleans', () => {

packages/sanity/src/core/studio/copyPaste/transferValue.ts

@@ -794,9 +794,13 @@ async function collateObjectValue({
     })
   }
 
-  // Special handling for weak references
-  if (isReferenceSchemaType(targetSchemaType) && targetSchemaType.weak) {
-    resultingValue._weak = true
+  // Special handling to avoid reference strength mismatches
+  if (isReferenceSchemaType(targetSchemaType)) {
+    if (targetSchemaType.weak) {
+      resultingValue._weak = true
+    } else {
+      delete resultingValue._weak
+    }
   }
 
   // Special handling for weak references that will be strengthened on publish
@@ -1034,7 +1038,7 @@ function collatePrimitiveValue({
 }
 
 function cleanObjectKeys(obj: TypedObject): TypedObject {
-  const disallowedKeys = ['_id', '_createdAt', '_updatedAt', '_rev', '_weak']
+  const disallowedKeys = ['_id', '_createdAt', '_updatedAt', '_rev']
   return Object.keys(obj).reduce((acc, key) => {
     if (disallowedKeys.includes(key)) {
       return acc