fix(core): slugs validation (#8951)

Author: pedrobonamin

packages/sanity/src/core/validation/validators/slugValidator.ts

@@ -10,18 +10,11 @@ import {
 } from '@sanity/types'
 import {memoize} from 'lodash'
 
-import {VERSION_FOLDER} from '../../util/draftUtils'
+import {DEFAULT_STUDIO_CLIENT_OPTIONS} from '../../studioClient'
+import {getPublishedId} from '../../util/draftUtils'
 
 const memoizedWarnOnArraySlug = memoize(warnOnArraySlug)
 
-function getDocumentIds(id: string) {
-  const isDraft = id.indexOf('drafts.') === 0
-  return {
-    published: isDraft ? id.slice('drafts.'.length) : id,
-    draft: isDraft ? id : `drafts.${id}`,
-  }
-}
-
 function serializePath(path: Path): string {
   return path.reduce<string>((target, part, i) => {
     const isIndex = typeof part === 'number'
@@ -44,7 +37,6 @@ const defaultIsUnique: SlugIsUniqueValidator = (slug, context) => {
   }
 
   const disableArrayWarning = schemaOptions?.disableArrayWarning || false
-  const {published, draft} = getDocumentIds(document._id)
   const docType = document._type
   const atPath = serializePath(path.concat('current'))
 
@@ -54,21 +46,21 @@ const defaultIsUnique: SlugIsUniqueValidator = (slug, context) => {
 
   const constraints = [
     '_type == $docType',
-    `!(_id in [$draft, $published])`,
-    `!(_id in path("${VERSION_FOLDER}.**.${published}"))`,
+    `!sanity::versionOf($published)`,
     `${atPath} == $slug`,
   ].join(' && ')
 
-  return getClient({apiVersion: '2023-11-13'}).fetch<boolean>(
-    `!defined(*[${constraints}][0]._id)`,
-    {
-      docType,
-      draft,
-      published,
-      slug,
-    },
-    {tag: 'validation.slug-is-unique'},
-  )
+  return getClient({apiVersion: DEFAULT_STUDIO_CLIENT_OPTIONS.apiVersion})
+    .withConfig({perspective: 'raw'})
+    .fetch<boolean>(
+      `!defined(*[${constraints}][0]._id)`,
+      {
+        docType,
+        published: getPublishedId(document._id),
+        slug,
+      },
+      {tag: 'validation.slug-is-unique'},
+    )
 }
 
 function warnOnArraySlug(serializedPath: string) {

packages/sanity/test/validation/infer.test.ts

@@ -146,10 +146,9 @@ describe('schema validation inference', () => {
 
       expect(client.fetch).toHaveBeenCalledTimes(1)
       expect(client.fetch.mock.calls[0]).toEqual([
-        '!defined(*[_type == $docType && !(_id in [$draft, $published]) && !(_id in path("versions.**.mockDocument")) && slugField.current == $slug][0]._id)',
+        '!defined(*[_type == $docType && !sanity::versionOf($published) && slugField.current == $slug][0]._id)',
         {
           docType: 'documentWithSlug',
-          draft: 'drafts.mockDocument',
           published: 'mockDocument',
           slug: 'example-value',
         },
@@ -185,10 +184,9 @@ describe('schema validation inference', () => {
 
       expect(client.fetch).toHaveBeenCalledTimes(1)
       expect(client.fetch.mock.calls[0]).toEqual([
-        '!defined(*[_type == $docType && !(_id in [$draft, $published]) && !(_id in path("versions.**.mockDocument")) && slugField.current == $slug][0]._id)',
+        '!defined(*[_type == $docType && !sanity::versionOf($published) && slugField.current == $slug][0]._id)',
         {
           docType: 'documentWithSlug',
-          draft: 'drafts.mockDocument',
           published: 'mockDocument',
           slug: 'example-value',
         },