Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused legacy react compiler build task #1304

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

stipsan
Copy link
Member

@stipsan stipsan commented Jan 8, 2025

The react-compiler export condition build pipeline were only used in inital experiments, to try and solve the alpha limitation of react 19.
Since then the compiler went beta and officially supports react 18 and our build pipeline is to install the babel-plugin-react-compiler on the library level, and enable it in package.config.ts: https://github.com/sanity-io/react-rx/blob/392cfdda744bae50e274ab087d76b1c0624cc511/package.config.ts#L12-L13

This PR cleans up the internal logic that isn't used anywhere and is thus not considered to be a breaking change.

@stipsan stipsan requested a review from a team as a code owner January 8, 2025 19:45
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/react@18.3.18 None +2 1.69 MB types
npm/react-compiler-runtime@19.0.0-beta-63e3235-20250105 None 0 42.9 kB react-bot
npm/react@18.3.1 environment +2 339 kB react-bot

View full report↗︎

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@stipsan stipsan force-pushed the remove-react-compiler-condition branch from be680bc to 431d40c Compare January 8, 2025 20:02
@stipsan stipsan merged commit 7ee3da7 into main Jan 8, 2025
3 checks passed
@stipsan stipsan deleted the remove-react-compiler-condition branch January 8, 2025 20:02
@ecospark ecospark bot mentioned this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant