fix: remove unused legacy react compiler build task #1304
Merged
+1,047
−291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
stipsan
force-pushed
the
remove-react-compiler-condition
branch
from
be680bc to
431d40c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
react-compilerexport condition build pipeline were only used in inital experiments, to try and solve the alpha limitation of react 19.Since then the compiler went beta and officially supports react 18 and our build pipeline is to install the
babel-plugin-react-compileron the library level, and enable it inpackage.config.ts: https://github.com/sanity-io/react-rx/blob/392cfdda744bae50e274ab087d76b1c0624cc511/package.config.ts#L12-L13This PR cleans up the internal logic that isn't used anywhere and is thus not considered to be a breaking change.