Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rename context_text.go to context_test.go #19

Merged

Conversation

joonas
Copy link
Contributor

@joonas joonas commented Jan 2, 2025

While looking over the changes in v0.18.0, I noticed this what I presumed to be a typo.

For some more context, this came up as a blocker for the automated update of slog-common from v0.17.1 to v0.18.0 in wasmCloud/go#105 since testify depends on net/http/httptest, which is currently not part of the TinyGo net package, which we use.

I've validated locally that making this change fixes the failing CI steps in the linked PR (wasmCloud/go#105)

Signed-off-by: Joonas Bergius <joonas@cosmonic.com>
@samber
Copy link
Owner

samber commented Jan 3, 2025

Thanks @joonas for reporting this typo.

Please upgrade to 0.18.1.

@samber samber merged commit bf0fd21 into samber:main Jan 3, 2025
1 check passed
@joonas joonas deleted the chore/rename-context_text-to-context_test branch January 4, 2025 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants