Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TECH DEBT] support for pysss can be removed #65029

Closed
nicholasmhughes opened this issue Aug 22, 2023 · 1 comment
Closed

[TECH DEBT] support for pysss can be removed #65029

nicholasmhughes opened this issue Aug 22, 2023 · 1 comment
Assignees

Comments

@nicholasmhughes
Copy link
Collaborator

nicholasmhughes commented Aug 22, 2023

Description of the tech debt to be addressed, include links and screenshots

...at least in the context of user management. It seems that there may have been a package called pysss which presumably offered user/group management capabilities.

However, that package is no longer related to that capability:

PyPi: https://pypi.org/project/pysss/

GitHub: https://github.com/mohamed/pysss

The sections below are referencing that package, and further digging should probably be done to see if it's used anywhere else.

https://github.com/saltstack/salt/blob/c9512a18537935ed44e798602920c18629125994/salt/utils/user.py#L34,L39

https://github.com/saltstack/salt/blob/c9512a18537935ed44e798602920c18629125994/salt/utils/user.py#L304,L310

Versions Report

3006.2/master (dated 2023-08-22)

@whytewolf
Copy link
Collaborator

Thank you for the ticket. I know you are setup to handle this and #64953 and #64888 together. so I"ll assign this to myself. let me know when you get that PR in.

nicholasmhughes added a commit to nicholasmhughes/salt that referenced this issue Aug 29, 2023

Verified

This commit was signed with the committer’s verified signature.
MarshallOfSound Samuel Attard
felippeb pushed a commit to felippeb/salt that referenced this issue Oct 27, 2023

Verified

This commit was signed with the committer’s verified signature.
MarshallOfSound Samuel Attard
felippeb pushed a commit to felippeb/salt that referenced this issue Oct 27, 2023

Verified

This commit was signed with the committer’s verified signature.
MarshallOfSound Samuel Attard
m-czernek pushed a commit to openSUSE/salt that referenced this issue Jul 2, 2024

Verified

This commit was signed with the committer’s verified signature.
MarshallOfSound Samuel Attard
* fixes saltstack/salt#64953 user.list_groups omits remote groups

* fixes saltstack/salt#65029 support for pysss can be removed

* add changlog entries

* add tests for _getgrall and local vs remote group handling

* add negative tests for _getgrall

* root can still read the file and tests run as root

* remove permission check as its probably an unreachable edge case

---------

Co-authored-by: nicholasmhughes <nicholasmhughes@gmail.com>
meaksh pushed a commit to openSUSE/salt that referenced this issue Oct 29, 2024
* fixes saltstack/salt#64953 user.list_groups omits remote groups

* fixes saltstack/salt#65029 support for pysss can be removed

* add changlog entries

* add tests for _getgrall and local vs remote group handling

* add negative tests for _getgrall

* root can still read the file and tests run as root

* remove permission check as its probably an unreachable edge case

---------

Co-authored-by: nicholasmhughes <nicholasmhughes@gmail.com>
agraul pushed a commit to agraul/salt that referenced this issue Jan 27, 2025
* fixes saltstack#64953 user.list_groups omits remote groups

* fixes saltstack#65029 support for pysss can be removed

* add changlog entries

* add tests for _getgrall and local vs remote group handling

* add negative tests for _getgrall

* root can still read the file and tests run as root

* remove permission check as its probably an unreachable edge case

---------

Co-authored-by: nicholasmhughes <nicholasmhughes@gmail.com>

BACKPORT-UPSTREAM=saltstack#65077
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants