Wr/spread base flags

[WillieRuemmele]

@W-15837411@

warning to encourage inheriting from SfCommand directly

/Users/william.ruemmele/projects/oss/plugin-devops-center/src/commands/project/deploy/pipeline/report.ts
  15:22  warning  In order to inherit default flags correctly, extend from SfCommand directly                          sf-plugin/only-extend-SfCommand

error when not spreading parent class' flags

  20:3   error            When not directly extending SfCommand, the parent's flags must be spread like flags = {...ReportOnPromoteCommand.flags}
  sf-plugin/spread-base-flags

warn for these rules until they can be fixed in the offending plugins
https://github.com/salesforcecli/eslint-plugin-sf-plugin/actions/runs/9976522635/job/27569016725?pr=441

[cristiand391]

QA notes:

setup:
build and installed eslint plugin as mentioned in the contributing doc, tested on plugin-data

sf-plugin/only-extend-SfCommand

✅ warn if not extending SfCommand directly
✅ only checks TS files in src/commands

sf-plugin/spread-base-flags

I was reading the WI again and I think it was meant to cover SfCommand.baseFlags being lost when extending SfCommand, but when I try that I always get a TS error if I don't spread SfCommand.baseFlags so I wonder if this rule needs to cover that.
https://github.com/salesforcecli/sf-plugins-core/blob/7f7fe9bab0896fd6a7f7414cb663226e60c6977c/src/sfCommand.ts#L123

✅ warn if extending SfCommand and not spreading SfCommand.flags
❓ SfCommand.flags isn't defined so commands extending SfCommand aren't missing any flags right now, do we need to keep this rule?
🟡 no autofix, is there a scenario where autofixing this would be bad?

[cristiand391]

sf-plugin/spread-base-flags

✅ cmd extends from SfCommand directly, no warns
✅ cmd extends dummy SfCommand wrapper, gets warn to spread Wrapper.flags:

abstract class Wrapper extends SfCommand<LalaResult> {}
export default class Lala extends Wrapper {
    ...
}

✅ same scenario from above but define baseFlags in Lala class, gets warn to spread Wrapper.baseFlags.
✅ cmd without flags or baseFlags doesn't get flagged by rule